LightZirconite/Microsoft-Rewards-Bot
1
1
Fork 0
mirror of https://github.com/LightZirconite/Microsoft-Rewards-Bot.git synced 2026-01-10 01:06:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: Reduce wait times for page stability checks in account creation process

Browse Source
This commit is contained in:
LightZirconite
2025-11-11 15:30:37 +01:00
parent 6069f2eba0
commit bcab53319a
1 changed files with 11 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/account-creation/AccountCreator.ts
View File

@@ -1166,7 +1166,7 @@ export class AccountCreator {
log(false, 'CREATOR', `Clicking Next button (${step})...`, 'log') log(false, 'CREATOR', `Clicking Next button (${step})...`, 'log')
// CRITICAL: Ensure page is stable before clicking // CRITICAL: Ensure page is stable before clicking
await this.waitForPageStable(`BEFORE_NEXT_${step.toUpperCase()}`, 15000) await this.waitForPageStable(`BEFORE_NEXT_${step.toUpperCase()}`, 8000)
// Find button by test id or type submit // Find button by test id or type submit
const nextBtn = this.page.locator('button[data-testid="primaryButton"], button[type="submit"]').first() const nextBtn = this.page.locator('button[data-testid="primaryButton"], button[type="submit"]').first()
@@ -1200,21 +1200,18 @@ export class AccountCreator {
await this.humanDelay(3000, 5000) await this.humanDelay(3000, 5000)
// CRITICAL: Wait for page to be stable after clicking // CRITICAL: Wait for page to be stable after clicking
await this.waitForPageStable(`AFTER_NEXT_${step.toUpperCase()}`, 20000) await this.waitForPageStable(`AFTER_NEXT_${step.toUpperCase()}`, 10000)
// CRITICAL: Verify the click was successful // CRITICAL: Verify the click was successful
const urlAfter = this.page.url() const urlAfter = this.page.url()
let clickSuccessful = false let clickSuccessful = false
if (urlBefore !== urlAfter) { if (urlBefore !== urlAfter) {
log(false, 'CREATOR', `✅ Navigation detected: ${urlBefore} → ${urlAfter}`, 'log', 'green') log(false, 'CREATOR', '✅ Navigation detected', 'log', 'green')
clickSuccessful = true clickSuccessful = true
} else { } else {
log(false, 'CREATOR', `URL unchanged after clicking Next (${step})`, 'log', 'yellow') // URL didn't change - check for errors (some pages don't change URL)
await this.humanDelay(1500, 2000)
// URL didn't change - this might be OK if content changed
// Wait a bit more and check for errors
await this.humanDelay(2000, 3000)
const hasErrors = !(await this.verifyNoErrors()) const hasErrors = !(await this.verifyNoErrors())
if (hasErrors) { if (hasErrors) {
@@ -1222,8 +1219,7 @@ export class AccountCreator {
return false return false
} }
// No errors - assume success (some pages don't change URL) // No errors - success (silent, no need to log)
log(false, 'CREATOR', `No errors detected, assuming Next (${step}) was successful`, 'log', 'yellow')
clickSuccessful = true clickSuccessful = true
} }
@@ -1233,9 +1229,9 @@ export class AccountCreator {
private async fillPassword(): Promise<string | null> { private async fillPassword(): Promise<string | null> {
await this.page.locator('h1[data-testid="title"]').first().waitFor({ timeout: 20000 }) await this.page.locator('h1[data-testid="title"]').first().waitFor({ timeout: 10000 })
await this.waitForPageStable('PASSWORD_PAGE', 15000) await this.waitForPageStable('PASSWORD_PAGE', 8000)
await this.humanDelay(1000, 2000) await this.humanDelay(800, 1500)
log(false, 'CREATOR', '🔐 Generating password...', 'log', 'cyan') log(false, 'CREATOR', '🔐 Generating password...', 'log', 'cyan')
const password = this.dataGenerator.generatePassword() const password = this.dataGenerator.generatePassword()
@@ -1311,7 +1307,7 @@ export class AccountCreator {
private async fillBirthdate(): Promise<{ day: number; month: number; year: number } | null> { private async fillBirthdate(): Promise<{ day: number; month: number; year: number } | null> {
log(false, 'CREATOR', '🎂 Filling birthdate...', 'log', 'cyan') log(false, 'CREATOR', '🎂 Filling birthdate...', 'log', 'cyan')
await this.waitForPageStable('BIRTHDATE_PAGE', 15000) await this.waitForPageStable('BIRTHDATE_PAGE', 8000)
const birthdate = this.dataGenerator.generateBirthdate() const birthdate = this.dataGenerator.generateBirthdate()
@@ -1496,7 +1492,7 @@ export class AccountCreator {
private async fillNames(email: string): Promise<{ firstName: string; lastName: string } | null> { private async fillNames(email: string): Promise<{ firstName: string; lastName: string } | null> {
log(false, 'CREATOR', '👤 Filling name...', 'log', 'cyan') log(false, 'CREATOR', '👤 Filling name...', 'log', 'cyan')
await this.waitForPageStable('NAMES_PAGE', 15000) await this.waitForPageStable('NAMES_PAGE', 8000)
const names = this.dataGenerator.generateNames(email) const names = this.dataGenerator.generateNames(email)