From 1b5f70a075bea27415e76fa907b7204a534b0268 Mon Sep 17 00:00:00 2001 From: Moyasee Date: Fri, 3 Oct 2025 03:01:37 +0300 Subject: [PATCH] Fix: replaced array index with review.id and marked props as read-only --- .../pages/game-details/game-details-content.tsx | 17 ++++------------- .../game-details/modals/delete-review-modal.tsx | 2 +- .../pages/game-details/review-prompt-banner.tsx | 2 +- .../pages/game-details/review-sort-options.tsx | 2 +- 4 files changed, 7 insertions(+), 16 deletions(-) diff --git a/src/renderer/src/pages/game-details/game-details-content.tsx b/src/renderer/src/pages/game-details/game-details-content.tsx index f3db5164..8a09712e 100644 --- a/src/renderer/src/pages/game-details/game-details-content.tsx +++ b/src/renderer/src/pages/game-details/game-details-content.tsx @@ -688,8 +688,8 @@ export function GameDetailsContent() { )} - {reviews.map((review, index) => ( -
+ {reviews.map((review) => ( +
{review.isBlocked && !visibleBlockedReviews.has(review.id) ? (
@@ -713,24 +713,15 @@ export function GameDetailsContent() { /> )}
-
review.user?.id && navigate(`/profile/${review.user.id}`) } - onKeyDown={(e) => { - if (e.key === "Enter" || e.key === " ") { - e.preventDefault(); - review.user?.id && - navigate(`/profile/${review.user.id}`); - } - }} - role="button" - tabIndex={0} > {review.user?.displayName || "Anonymous"} -
+
{formatDistance( diff --git a/src/renderer/src/pages/game-details/modals/delete-review-modal.tsx b/src/renderer/src/pages/game-details/modals/delete-review-modal.tsx index 2ed352c5..fe612bbd 100644 --- a/src/renderer/src/pages/game-details/modals/delete-review-modal.tsx +++ b/src/renderer/src/pages/game-details/modals/delete-review-modal.tsx @@ -12,7 +12,7 @@ export function DeleteReviewModal({ visible, onClose, onConfirm, -}: DeleteReviewModalProps) { +}: Readonly) { const { t } = useTranslation("game_details"); const handleDeleteReview = () => { diff --git a/src/renderer/src/pages/game-details/review-prompt-banner.tsx b/src/renderer/src/pages/game-details/review-prompt-banner.tsx index 7bd96613..aeddaaad 100644 --- a/src/renderer/src/pages/game-details/review-prompt-banner.tsx +++ b/src/renderer/src/pages/game-details/review-prompt-banner.tsx @@ -10,7 +10,7 @@ interface ReviewPromptBannerProps { export function ReviewPromptBanner({ onYesClick, onLaterClick, -}: ReviewPromptBannerProps) { +}: Readonly) { const { t } = useTranslation("game_details"); return ( diff --git a/src/renderer/src/pages/game-details/review-sort-options.tsx b/src/renderer/src/pages/game-details/review-sort-options.tsx index ca11d056..75ec0f39 100644 --- a/src/renderer/src/pages/game-details/review-sort-options.tsx +++ b/src/renderer/src/pages/game-details/review-sort-options.tsx @@ -21,7 +21,7 @@ interface ReviewSortOptionsProps { export function ReviewSortOptions({ sortBy, onSortChange, -}: ReviewSortOptionsProps) { +}: Readonly) { const { t } = useTranslation("game_details"); const handleDateToggle = () => {