From c2216bbf95fe5899f87e6a60514994a11cd591c1 Mon Sep 17 00:00:00 2001
From: Zamitto <167933696+zamitto@users.noreply.github.com>
Date: Wed, 12 Nov 2025 08:17:53 -0300
Subject: [PATCH] feat: use jpg for system notifications

---
 python_rpc/main.py                               | 5 ++++-
 python_rpc/profile_image_processor.py            | 8 ++++----
 src/main/events/profile/process-profile-image.ts | 6 +++---
 src/main/services/notifications/index.ts         | 2 +-
 src/main/services/ws/events/friend-request.ts    | 8 +++++---
 5 files changed, 17 insertions(+), 12 deletions(-)

diff --git a/python_rpc/main.py b/python_rpc/main.py
index 36170025..99dd0d8c 100644
--- a/python_rpc/main.py
+++ b/python_rpc/main.py
@@ -153,8 +153,11 @@ def profile_image():
     data = request.get_json()
     image_path = data.get('image_path')
 
+    # use webp as default value for target_extension
+    target_extension = data.get('target_extension') or 'webp'
+
     try:
-        processed_image_path, mime_type = ProfileImageProcessor.process_image(image_path)
+        processed_image_path, mime_type = ProfileImageProcessor.process_image(image_path, target_extension)
         return jsonify({'imagePath': processed_image_path, 'mimeType': mime_type}), 200
     except Exception as e:
         return jsonify({"error": str(e)}), 400
diff --git a/python_rpc/profile_image_processor.py b/python_rpc/profile_image_processor.py
index 45ba5160..eac8c32a 100644
--- a/python_rpc/profile_image_processor.py
+++ b/python_rpc/profile_image_processor.py
@@ -4,7 +4,7 @@ import os, uuid, tempfile
 class ProfileImageProcessor:
     
     @staticmethod
-    def get_parsed_image_data(image_path):
+    def get_parsed_image_data(image_path, target_extension):
         Image.MAX_IMAGE_PIXELS = 933120000
         
         image = Image.open(image_path)
@@ -16,7 +16,7 @@ class ProfileImageProcessor:
             return image_path, mime_type
         else:
             new_uuid = str(uuid.uuid4())
-            new_image_path = os.path.join(tempfile.gettempdir(), new_uuid) + ".webp"
+            new_image_path = os.path.join(tempfile.gettempdir(), new_uuid) + "." + target_extension
             image.save(new_image_path)
             
             new_image = Image.open(new_image_path)
@@ -26,5 +26,5 @@ class ProfileImageProcessor:
                 
     
     @staticmethod
-    def process_image(image_path):
-        return ProfileImageProcessor.get_parsed_image_data(image_path)
+    def process_image(image_path, target_extension):
+        return ProfileImageProcessor.get_parsed_image_data(image_path, target_extension)
diff --git a/src/main/events/profile/process-profile-image.ts b/src/main/events/profile/process-profile-image.ts
index 9407f0a2..bec17cb6 100644
--- a/src/main/events/profile/process-profile-image.ts
+++ b/src/main/events/profile/process-profile-image.ts
@@ -5,15 +5,15 @@ const processProfileImageEvent = async (
   _event: Electron.IpcMainInvokeEvent,
   path: string
 ) => {
-  return processProfileImage(path);
+  return processProfileImage(path, "webp");
 };
 
-export const processProfileImage = async (path: string) => {
+export const processProfileImage = async (path: string, extension?: string) => {
   return PythonRPC.rpc
     .post<{
       imagePath: string;
       mimeType: string;
-    }>("/profile-image", { image_path: path })
+    }>("/profile-image", { image_path: path, target_extension: extension })
     .then((response) => response.data);
 };
 
diff --git a/src/main/services/notifications/index.ts b/src/main/services/notifications/index.ts
index 6ad93ea7..a925e7c7 100644
--- a/src/main/services/notifications/index.ts
+++ b/src/main/services/notifications/index.ts
@@ -18,7 +18,7 @@ import { getThemeSoundPath } from "@main/helpers";
 import { processProfileImage } from "@main/events/profile/process-profile-image";
 
 const getStaticImage = async (path: string) => {
-  return processProfileImage(path)
+  return processProfileImage(path, "jpg")
     .then((response) => response.imagePath)
     .catch(() => path);
 };
diff --git a/src/main/services/ws/events/friend-request.ts b/src/main/services/ws/events/friend-request.ts
index 8faa38a5..efee370d 100644
--- a/src/main/services/ws/events/friend-request.ts
+++ b/src/main/services/ws/events/friend-request.ts
@@ -8,9 +8,11 @@ export const friendRequestEvent = async (payload: FriendRequest) => {
     friendRequestCount: payload.friendRequestCount,
   });
 
-  const user = await HydraApi.get(`/users/${payload.senderId}`);
+  if (payload.senderId) {
+    const user = await HydraApi.get(`/users/${payload.senderId}`);
 
-  if (user) {
-    publishNewFriendRequestNotification(user);
+    if (user) {
+      publishNewFriendRequestNotification(user);
+    }
   }
 };