refactor: remove unnecessary useEffect in LibraryGameCard

refactor: improve code formatting and consistency in DownloadManager

src/main/services/download/download-manager.ts

@@ -35,18 +35,27 @@ export class DownloadManager {
   ): string | undefined {
     if (originalUrl?.includes("#")) {
       const hashPart = originalUrl.split("#")[1];
-      if (hashPart && !hashPart.startsWith("http")) return hashPart;
+      if (hashPart && !hashPart.startsWith("http") && hashPart.includes(".")) {
+        return hashPart;
+      }
     }
 
     if (url.includes("#")) {
       const hashPart = url.split("#")[1];
-      if (hashPart && !hashPart.startsWith("http")) return hashPart;
+      if (hashPart && !hashPart.startsWith("http") && hashPart.includes(".")) {
+        return hashPart;
+      }
     }
 
     try {
       const urlObj = new URL(url);
-      const filename = urlObj.pathname.split("/").pop();
+      const pathname = urlObj.pathname;
-      if (filename?.length) return filename;
+      const pathParts = pathname.split("/");
+      const filename = pathParts[pathParts.length - 1];
+
+      if (filename?.includes(".") && filename.length > 0) {
+        return decodeURIComponent(filename);
+      }
     } catch {
       // Invalid URL
     }
@@ -55,7 +64,7 @@ export class DownloadManager {
   }
 
   private static sanitizeFilename(filename: string): string {
-    return filename.replace(/[<>:"/\\|?*]/g, "_");
+    return filename.replaceAll(/[<>:"/\\|?*]/g, "_");
   }
 
   private static createDownloadPayload(
@@ -64,13 +73,19 @@ export class DownloadManager {
     downloadId: string,
     savePath: string
   ) {
-    const filename = this.extractFilename(directUrl, originalUrl);
+    const filename =
+      this.extractFilename(originalUrl, directUrl) ||
+      this.extractFilename(directUrl);
     const sanitizedFilename = filename
       ? this.sanitizeFilename(filename)
       : undefined;
 
     if (sanitizedFilename) {
       logger.log(`[DownloadManager] Using filename: ${sanitizedFilename}`);
+    } else {
+      logger.log(
+        `[DownloadManager] No filename extracted, aria2 will use default`
+      );
     }
 
     return {
@@ -227,10 +242,10 @@ export class DownloadManager {
             )
           ) {
             gameFilesManager.extractDownloadedFile();
-          } else {
+          } else if (download.folderName) {
             gameFilesManager
               .extractFilesInDirectory(
-                path.join(download.downloadPath, download.folderName!)
+                path.join(download.downloadPath, download.folderName)
               )
               .then(() => gameFilesManager.setExtractionComplete());
           }

src/renderer/src/pages/library/library-game-card.scss

@@ -221,6 +221,26 @@
     left: 0;
     z-index: 0;
   }
+
+  &__cover-placeholder {
+    position: relative;
+    width: 100%;
+    height: 100%;
+    min-width: 100%;
+    min-height: 100%;
+    background: linear-gradient(
+      90deg,
+      rgba(255, 255, 255, 0.08) 0%,
+      rgba(255, 255, 255, 0.04) 50%,
+      rgba(255, 255, 255, 0.08) 100%
+    );
+    border-radius: 4px;
+    color: rgba(255, 255, 255, 0.3);
+    display: flex;
+    align-items: center;
+    justify-content: center;
+    z-index: 0;
+  }
 }
 
 @keyframes pulse {

src/renderer/src/pages/library/library-game-card.tsx

@@ -1,7 +1,12 @@
 import { LibraryGame } from "@types";
 import { useGameCard } from "@renderer/hooks";
-import { memo } from "react";
+import { memo, useState } from "react";
-import { ClockIcon, AlertFillIcon, TrophyIcon } from "@primer/octicons-react";
+import {
+  ClockIcon,
+  AlertFillIcon,
+  TrophyIcon,
+  ImageIcon,
+} from "@primer/octicons-react";
 import "./library-game-card.scss";
 
 interface LibraryGameCardProps {
@@ -25,14 +30,9 @@ export const LibraryGameCard = memo(function LibraryGameCard({
   const { formatPlayTime, handleCardClick, handleContextMenuClick } =
     useGameCard(game, onContextMenu);
 
-  const coverImage = (
+  const coverImage = game.coverImageUrl?.replaceAll("\\", "/") ?? "";
-    game.customIconUrl ??
+
-    game.coverImageUrl ??
+  const [imageError, setImageError] = useState(false);
-    game.libraryImageUrl ??
-    game.libraryHeroImageUrl ??
-    game.iconUrl ??
-    ""
-  ).replaceAll("\\", "/");
 
   return (
     <button
@@ -98,12 +98,19 @@ export const LibraryGameCard = memo(function LibraryGameCard({
         )}
       </div>
 
-      <img
+      {imageError || !coverImage ? (
-        src={coverImage ?? undefined}
+        <div className="library-game-card__cover-placeholder">
-        alt={game.title}
+          <ImageIcon size={48} />
-        className="library-game-card__game-image"
+        </div>
-        loading="lazy"
+      ) : (
-      />
+        <img
+          src={coverImage}
+          alt={game.title}
+          className="library-game-card__game-image"
+          loading="lazy"
+          onError={() => setImageError(true)}
+        />
+      )}
     </button>
   );
 });