More consistency and bringing debian script on par with arch

arch-setup.sh

@@ -11,6 +11,22 @@ install_packages() {
     done
 }
 
+# Function name: Install package
+# Description: Install a package
+# Arguments:
+#   $1: Package name
+install_package() {
+    sudo pacman -S --needed --noconfirm "$1"
+}
+
+# Function name: Install dependencies
+# Description: Install dependencies
+# Arguments:
+#   $1: Package name
+install_dependencies() {
+    sudo pacman -S --needed --noconfirm --asdeps "$1"
+}
+
 # Function name: Check whiptail
 # Description: Check if whiptail is installed else install it
 check_whiptail() {
@@ -344,7 +360,7 @@ setup_browser() {
 # function name : setup u2f
 # Description: setup u2f
 setup_u2f() {
-    sudo pacman -S --needed --noconfirm pam-u2f
+    install_package pam-u2f
     mkdir ~/.config/Yubico
     echo "Registering U2F device..."
     pamu2fcfg -o "pam://$HOST" -i "pam://$HOST" > ~/.config/Yubico/u2f_keys
@@ -364,7 +380,7 @@ setup_u2f() {
 # function name : setup OpenRGB
 # Description: setup OpenRGB
 setup_openrgb() {
-    sudo pacman -S --needed --noconfirm openrgb
+    install_package openrgb
     sudo gpasswd -a "$USER" plugdev
     sudo systemctl enable --now openrgb
 }
@@ -428,7 +444,7 @@ install_packages_group() {
 			install_packages containers_packages[@]
             # if nvidia gpu is detected
             if lspci | grep -Ei "nvidia" > /dev/null; then
-                sudo pacman -S --needed --noconfirm nvidia-container-toolkit
+                install_package nvidia-container-toolkit
             fi
 		;;
 			"\"U2F\"")
@@ -457,19 +473,21 @@ setup_firewall() {
 
     case $selected_groups in
         "ufw")
-            sudo pacman -S --needed --noconfirm ufw ufw-extras
+            install_package ufw 
+            install_dependencies ufw-extras
             sudo systemctl enable --now ufw
             sudo ufw enable
         ;;
         "firewalld")
-            sudo pacman -S --needed --noconfirm firewalld
+            install_package firewalld
             sudo systemctl enable --now firewalld
         ;;
         "iptables")
-            sudo pacman -S --needed --noconfirm iptables
+            install_package iptables
         ;;
         "nftables")
-            sudo pacman -S --needed --noconfirm nftables iptables-nft
+            install_package nftables 
+            install_package iptables-nft
         ;;
     esac
 }
@@ -478,7 +496,7 @@ setup_firewall() {
 # Description: setup flatpak
 setup_flatpak() {
     if whiptail --title "Setup Flatpak" --yesno "Would you like to setup Flatpak?" 10 60; then
-        sudo pacman -S --needed --noconfirm flatpak
+        install_package flatpak
         flatpak remote-add --if-not-exists --system flathub https://flathub.org/repo/flathub.flatpakrepo
     fi
 }
@@ -487,7 +505,8 @@ setup_flatpak() {
 # Description: setup fwupd
 setup_fwupd() {
     if whiptail --title "Setup fwupd" --yesno "Would you like to setup fwupd?" 10 60; then
-        sudo pacman -S --needed fwupd fwupd-efi
+        install_package fwupd 
+        install_dependencies fwupd-efi
         sudo systemctl enable --now fwupd
         sudo systemctl enable --now fwupd-refresh
     fi
@@ -504,10 +523,10 @@ setup_kdeconnect() {
         selected_option=$(whiptail --title "Setup KDE Connect" --radiolist "Choose the package you want to install:" 20 78 2 "${options[@]}" 3>&1 1>&2 2>&3)
         case $selected_option in
             "\"kdeconnect\"")
-                sudo pacman -S --needed --noconfirm kdeconnect
+                install_package kdeconnect
             ;;
             "\"gsconnect\"")
-                sudo yay -S --needed --noconfirm gsconnect gnome-shell-extension-gsconnect
+                install_package gnome-shell-extension-gsconnect
             ;;
         esac
     fi
@@ -525,16 +544,16 @@ setup_office_suite() {
     selected_option=$(whiptail --title "Setup Office Suite" --radiolist "Choose the office suite you want to install:" 20 78 4 "${options[@]}" 3>&1 1>&2 2>&3)
     case $selected_option in
         "\"LibreOffice\"")
-            sudo pacman -S --needed --noconfirm libreoffice-fresh
+            install_package libreoffice-fresh
         ;;
         "\"OnlyOffice\"")
-            sudo pacman -S --needed --noconfirm onlyoffice-bin
+            install_package onlyoffice-bin
         ;;
         "\"WPS Office\"")
-            sudo pacman -S --needed --noconfirm wps-office
+            install_package wps-office
         ;;
         "\"FreeOffice\"")
-            sudo pacman -S --needed --noconfirm freeoffice
+            install_package freeoffice
         ;;
     esac
 }