From d55b101f1bb54f9c3f2aa95d212114d3c16353cf Mon Sep 17 00:00:00 2001 From: momo5502 Date: Fri, 10 Jan 2025 07:04:22 +0100 Subject: [PATCH 1/2] Add build platform --- .github/workflows/build.yml | 38 +++++++++++++++++++++++++++---------- 1 file changed, 28 insertions(+), 10 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index f29d1c27..dde4b769 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -126,7 +126,9 @@ jobs: fail-fast: false matrix: platform: - - Windows + - Windows 2025 + - Windows 2022 + - Windows 2019 - Linux GCC - Linux Clang - macOS @@ -138,30 +140,40 @@ jobs: preset: debug - configuration: Release preset: release - - platform: Windows - runner: windows-latest + - platform: Windows 2025 + build-platform: Windows + runner: windows-2025 + - platform: Windows 2022 + build-platform: Windows + runner: windows-2022 + - platform: Windows 2019 + build-platform: Windows + runner: windows-2019 - platform: Linux GCC + build-platform: Linux GCC runner: ubuntu-24.04 - platform: Linux Clang + build-platform: Linux Clang runner: ubuntu-24.04 - platform: macOS + build-platform: macOS runner: macos-latest steps: - name: Download Test Config uses: actions/download-artifact@v4 with: - name: Temp ${{ matrix.platform }} ${{matrix.configuration}} Test Config + name: Temp ${{ matrix.build-platform }} ${{matrix.configuration}} Test Config path: build/${{matrix.preset}} - name: Download Artifacts uses: actions/download-artifact@v4 with: - name: ${{ matrix.platform }} ${{matrix.configuration}} Artifacts + name: ${{ matrix.build-platform }} ${{matrix.configuration}} Artifacts path: build/${{matrix.preset}}/artifacts - name: Download Windows Artifacts uses: actions/download-artifact@v4 - if: "${{ matrix.platform != 'Windows' }}" + if: "${{ matrix.build-platform != 'Windows' }}" with: name: Windows ${{matrix.configuration}} Artifacts path: build/${{matrix.preset}}/artifacts @@ -174,14 +186,20 @@ jobs: - name: CMake Test run: cd build/${{matrix.preset}} && ctest --verbose - if: "${{ matrix.platform == 'Windows' }}" + if: "${{ matrix.build-platform == 'Windows' }}" - cleanup: - name: Cleanup Artifacts + summary: + name: Pipeline Summary runs-on: ubuntu-24.04 - needs: [dump-registry, build, test] + needs: [dump-registry, build, test, verify-formatting] if: always() steps: - uses: geekyeggo/delete-artifact@v5 with: name: 'Temp *' + - name: Pipeline suceeded + if: ${{ !(contains(needs.*.result, 'failure')) }} + run: exit 0 + - name: Pipeline failed + if: ${{ contains(needs.*.result, 'failure') }} + run: exit 1 From da5a710f446f7509632993005cb0e72536744fd8 Mon Sep 17 00:00:00 2001 From: momo5502 Date: Fri, 10 Jan 2025 07:14:34 +0100 Subject: [PATCH 2/2] Disable windows 10 for now --- .github/workflows/build.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index dde4b769..4fdce935 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -126,9 +126,10 @@ jobs: fail-fast: false matrix: platform: + # TODO: Move different windows platforms into registry dump matrix - Windows 2025 - Windows 2022 - - Windows 2019 + #- Windows 2019 - Linux GCC - Linux Clang - macOS @@ -146,9 +147,9 @@ jobs: - platform: Windows 2022 build-platform: Windows runner: windows-2022 - - platform: Windows 2019 - build-platform: Windows - runner: windows-2019 + #- platform: Windows 2019 + # build-platform: Windows + # runner: windows-2019 - platform: Linux GCC build-platform: Linux GCC runner: ubuntu-24.04