From 2cb14a35554d1a219622c963ff1afaa33b2b8436 Mon Sep 17 00:00:00 2001
From: momo5502 <mauriceheumann@gmail.com>
Date: Wed, 19 Mar 2025 17:56:35 +0100
Subject: [PATCH] Make sure to create reproducible emulator

---
 src/windows-emulator-test/emulation_test.cpp       | 4 ++--
 src/windows-emulator-test/emulation_test_utils.hpp | 5 +++++
 src/windows-emulator-test/serialization_test.cpp   | 8 --------
 3 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/src/windows-emulator-test/emulation_test.cpp b/src/windows-emulator-test/emulation_test.cpp
index f5833843..8d92439b 100644
--- a/src/windows-emulator-test/emulation_test.cpp
+++ b/src/windows-emulator-test/emulation_test.cpp
@@ -22,14 +22,14 @@ namespace test
 
     TEST(EmulationTest, CountedEmulationIsAccurate)
     {
-        auto emu = create_sample_emulator();
+        auto emu = create_reproducible_sample_emulator();
         emu.start();
 
         ASSERT_TERMINATED_SUCCESSFULLY(emu);
 
         const auto executedInstructions = emu.get_executed_instructions();
 
-        auto new_emu = create_sample_emulator();
+        auto new_emu = create_reproducible_sample_emulator();
 
         constexpr auto offset = 1;
         const auto instructionsToExecute = executedInstructions - offset;
diff --git a/src/windows-emulator-test/emulation_test_utils.hpp b/src/windows-emulator-test/emulation_test_utils.hpp
index a6e8a7ec..cab014c1 100644
--- a/src/windows-emulator-test/emulation_test_utils.hpp
+++ b/src/windows-emulator-test/emulation_test_utils.hpp
@@ -95,6 +95,11 @@ namespace test
         return create_sample_emulator(std::move(settings), config);
     }
 
+    inline windows_emulator create_reproducible_sample_emulator()
+    {
+        return create_sample_emulator({.reproducible = true});
+    }
+
     inline void bisect_emulation(windows_emulator& emu)
     {
         utils::buffer_serializer start_state{};
diff --git a/src/windows-emulator-test/serialization_test.cpp b/src/windows-emulator-test/serialization_test.cpp
index a14b7e89..803d4046 100644
--- a/src/windows-emulator-test/serialization_test.cpp
+++ b/src/windows-emulator-test/serialization_test.cpp
@@ -2,14 +2,6 @@
 
 namespace test
 {
-    namespace
-    {
-        auto create_reproducible_sample_emulator()
-        {
-            return create_sample_emulator({.reproducible = true});
-        }
-    }
-
     TEST(SerializationTest, ResettingEmulatorWorks)
     {
         auto emu = create_reproducible_sample_emulator();