From a16c1dd65417c5821213acbe7eb0b0403ba60aeb Mon Sep 17 00:00:00 2001
From: Elias Bachaalany <elias.bachaalany@gmail.com>
Date: Sun, 12 Jan 2025 12:31:53 -0800
Subject: [PATCH] renamed dependency 'common' to emulator-common

also made it mandatory when using the 'windows-emulator' dep
---
 src/analyzer/CMakeLists.txt              | 1 -
 src/bad-sample/CMakeLists.txt            | 2 +-
 src/common/CMakeLists.txt                | 6 +++---
 src/fuzzer/CMakeLists.txt                | 1 -
 src/fuzzing-engine/CMakeLists.txt        | 2 +-
 src/unicorn-emulator/CMakeLists.txt      | 2 +-
 src/windows-emulator-test/CMakeLists.txt | 1 -
 src/windows-emulator/CMakeLists.txt      | 2 +-
 8 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/src/analyzer/CMakeLists.txt b/src/analyzer/CMakeLists.txt
index 13b46b08..54c497d1 100644
--- a/src/analyzer/CMakeLists.txt
+++ b/src/analyzer/CMakeLists.txt
@@ -13,7 +13,6 @@ momo_assign_source_group(${SRC_FILES})
 target_precompile_headers(analyzer PRIVATE std_include.hpp)
 
 target_link_libraries(analyzer PRIVATE
-  common
   reflect
   windows-emulator
 )
diff --git a/src/bad-sample/CMakeLists.txt b/src/bad-sample/CMakeLists.txt
index 2e6e2502..eb1d6316 100644
--- a/src/bad-sample/CMakeLists.txt
+++ b/src/bad-sample/CMakeLists.txt
@@ -7,6 +7,6 @@ file(GLOB_RECURSE SRC_FILES CONFIGURE_DEPENDS
 list(SORT SRC_FILES)
 
 add_executable(bad-sample ${SRC_FILES})
-target_link_libraries(bad-sample PRIVATE common)
+target_link_libraries(bad-sample PRIVATE emulator-common)
 
 momo_assign_source_group(${SRC_FILES})
diff --git a/src/common/CMakeLists.txt b/src/common/CMakeLists.txt
index dd09f43b..42753b78 100644
--- a/src/common/CMakeLists.txt
+++ b/src/common/CMakeLists.txt
@@ -3,14 +3,14 @@ file(GLOB_RECURSE SRC_FILES CONFIGURE_DEPENDS
   *.hpp
 )
 
-add_library(common ${SRC_FILES})
+add_library(emulator-common ${SRC_FILES})
 
 momo_assign_source_group(${SRC_FILES})
 
-target_include_directories(common INTERFACE "${CMAKE_CURRENT_LIST_DIR}")
+target_include_directories(emulator-common INTERFACE "${CMAKE_CURRENT_LIST_DIR}")
 
 set(THREADS_PREFER_PTHREAD_FLAG ON)
 find_package(Threads REQUIRED)
-target_link_libraries(common PUBLIC
+target_link_libraries(emulator-common PUBLIC
   Threads::Threads
 )
diff --git a/src/fuzzer/CMakeLists.txt b/src/fuzzer/CMakeLists.txt
index a06cae8b..8a7b600a 100644
--- a/src/fuzzer/CMakeLists.txt
+++ b/src/fuzzer/CMakeLists.txt
@@ -13,7 +13,6 @@ momo_assign_source_group(${SRC_FILES})
 target_precompile_headers(fuzzer PRIVATE std_include.hpp)
 
 target_link_libraries(fuzzer PRIVATE
-  common
   fuzzing-engine
   windows-emulator
 )
diff --git a/src/fuzzing-engine/CMakeLists.txt b/src/fuzzing-engine/CMakeLists.txt
index bda32d22..90ecd42b 100644
--- a/src/fuzzing-engine/CMakeLists.txt
+++ b/src/fuzzing-engine/CMakeLists.txt
@@ -11,7 +11,7 @@ add_library(fuzzing-engine ${SRC_FILES})
 momo_assign_source_group(${SRC_FILES})
 
 target_link_libraries(fuzzing-engine PRIVATE
-  common
+  emulator-common
 )
 
 target_include_directories(fuzzing-engine INTERFACE
diff --git a/src/unicorn-emulator/CMakeLists.txt b/src/unicorn-emulator/CMakeLists.txt
index 80df01fe..f86f2870 100644
--- a/src/unicorn-emulator/CMakeLists.txt
+++ b/src/unicorn-emulator/CMakeLists.txt
@@ -17,4 +17,4 @@ target_include_directories(unicorn-emulator INTERFACE
 )
 
 target_link_libraries(unicorn-emulator PUBLIC emulator)
-target_link_libraries(unicorn-emulator PRIVATE unicorn common)
+target_link_libraries(unicorn-emulator PRIVATE unicorn emulator-common)
diff --git a/src/windows-emulator-test/CMakeLists.txt b/src/windows-emulator-test/CMakeLists.txt
index 42f1934b..0bffacc1 100644
--- a/src/windows-emulator-test/CMakeLists.txt
+++ b/src/windows-emulator-test/CMakeLists.txt
@@ -12,7 +12,6 @@ momo_assign_source_group(${SRC_FILES})
 
 target_link_libraries(windows-emulator-test PRIVATE
   gtest
-  common
   windows-emulator
 )
 
diff --git a/src/windows-emulator/CMakeLists.txt b/src/windows-emulator/CMakeLists.txt
index 0fb26ae9..b2ffe79c 100644
--- a/src/windows-emulator/CMakeLists.txt
+++ b/src/windows-emulator/CMakeLists.txt
@@ -13,12 +13,12 @@ momo_assign_source_group(${SRC_FILES})
 target_precompile_headers(windows-emulator PRIVATE std_include.hpp)
 
 target_link_libraries(windows-emulator PRIVATE
-  common
   unicorn-emulator
   mini-gdbstub
 )
 
 target_link_libraries(windows-emulator PUBLIC
+  emulator-common
   emulator
 )