fix(apis/websocket): improve logging and error handling

apis/websocket/src/events/parseImage.ts

@@ -16,19 +16,18 @@ const parseImageEventHandler: EventHandler<ClientOperation.ParseImage> = async (
 
     const nextSeq = client.currentSequence++
 
-    logger.debug(`Client ${client.id} requested to parse image from URL:`, imageUrl)
-    logger.debug(`Queue currently has ${queue.remaining}/${config.ocrConcurrentQueues} items in it`)
+    logger.debug(`Client ${client.id} requested to parse image from URL (${nextSeq})`, imageUrl)
 
     if (queue.remaining < config.ocrConcurrentQueues) queue.shift()
     await queue.wait()
 
-    try {
-        logger.debug(`Recognizing image from URL for client ${client.id}`)
+    logger.debug(`Process queued (${nextSeq}), queue has ${queue.remaining} items`)
 
+    try {
         const { data, jobId } = await tesseract.recognize(imageUrl)
 
-        logger.debug(`Recognized image from URL for client ${client.id} (job ${jobId}):`, data.text)
-        await client.send(
+        logger.debug(`Image parsed (job ${jobId}) (${nextSeq}):`, data.text)
+        client.send(
             {
                 op: ServerOperation.ParsedImage,
                 d: {
@@ -37,20 +36,20 @@ const parseImageEventHandler: EventHandler<ClientOperation.ParseImage> = async (
             },
             nextSeq,
         )
-    } catch {
-        logger.error(`Failed to parse image from URL for client ${client.id}:`, imageUrl)
-        await client.send(
-            {
-                op: ServerOperation.ParseImageFailed,
-                d: null,
-            },
-            nextSeq,
-        )
+    } catch (e) {
+        if (!client.disconnected)
+            client.send(
+                {
+                    op: ServerOperation.ParseImageFailed,
+                    d: null,
+                },
+                nextSeq,
+            )
+        else logger.warn(`Client disconnected before the failed packet could be sent (${nextSeq})`)
+        logger.error(`Failed to parse image (${nextSeq}):`, e)
     } finally {
         queue.shift()
-        logger.debug(
-            `Finished processing image from URL for client ${client.id}, queue has ${queue.remaining}/${config.ocrConcurrentQueues} remaining items in it`,
-        )
+        logger.debug(`Finished parsing image (${nextSeq}), queue has ${queue.remaining} items`)
     }
 }