fix(bots/discord): hanging process when disconnecting from API too many times

biome.json

@@ -21,6 +21,9 @@
         },
         "useNodejsImportProtocol": {
           "level": "off"
+        },
+        "useNumberNamespace": {
+          "level": "off"
         }
       }
     }

bots/discord/docs/4_commands_and_events.md

@@ -35,8 +35,6 @@ export default {
     data: new SlashCommandBuilder()
         .setName("my-command")
         .setDescription("My cool command")
-        // Allowing this command to be used in DMs
-        .setDMPermission(true)
         // DO NOT forget this line!
         .toJSON(),
 

bots/discord/src/events/api/disconnect.ts

@@ -16,7 +16,7 @@ withContext(on, 'disconnect', ({ api, config, logger }, reason, msg) => {
     )
 
     if (api.disconnectCount >= (config.api.disconnectLimit ?? 3)) {
-        console.error('Disconnected from bot API too many times')
+        logger.fatal('Disconnected from bot API too many times')
         // We don't want the process hanging
         process.exit(1)
     }

packages/api/src/classes/ClientWebSocket.ts

@@ -49,19 +49,13 @@ export class ClientWebSocketManager {
                 const timeout = setTimeout(() => {
                     if (!this.ready) {
                         this.#socket?.close(DisconnectReason.TooSlow)
-                        throw new Error('WebSocket connection was not readied in time')
+                        this._handleDisconnect(DisconnectReason.TooSlow, 'WebSocket connection was not readied in time')
                     }
                 }, this.timeout)
 
-                const errorBeforeReadyHandler = (err: Error) => {
-                    cleanup()
-                    throw err
-                }
-
                 const closeBeforeReadyHandler = (code: number, reason: Buffer) => {
-                    clearTimeout(timeout)
                     this._handleDisconnect(code, reason.toString())
-                    throw new Error('WebSocket connection closed before ready')
+                    cleanup()
                 }
 
                 const readyHandler = () => {
@@ -71,15 +65,14 @@ export class ClientWebSocketManager {
                     rs()
                 }
 
+                const socket = this.#socket
                 const cleanup = () => {
-                    this.#socket.off('open', readyHandler)
+                    socket.off('open', readyHandler)
-                    this.#socket.off('close', closeBeforeReadyHandler)
+                    socket.off('close', closeBeforeReadyHandler)
-                    this.#socket.off('error', errorBeforeReadyHandler)
                     clearTimeout(timeout)
                 }
 
                 this.#socket.on('open', readyHandler)
-                this.#socket.on('error', errorBeforeReadyHandler)
                 this.#socket.on('close', closeBeforeReadyHandler)
             } catch (e) {
                 rj(e)

semantic-release-config.js

@@ -26,7 +26,7 @@ const Options = {
                       '@semantic-release/npm',
                       {
                           npmPublish: false,
-                      }
+                      },
                   ],
                   [
                       '@semantic-release/git',