fix: resource patcher

src/main/kotlin/app/revanced/cli/MainCommand.kt

@@ -1,96 +0,0 @@
-package app.revanced.cli
-
-import app.revanced.patcher.PatcherOptions
-import app.revanced.patcher.annotation.Name
-import app.revanced.patcher.util.patch.implementation.JarPatchBundle
-import app.revanced.utils.adb.Adb
-import app.revanced.utils.patcher.addPatchesFiltered
-import app.revanced.utils.signature.Signature
-import picocli.CommandLine.*
-import java.io.File
-
-@Command(
-    name = "ReVanced-CLI", version = ["1.0.0"], mixinStandardHelpOptions = true
-)
-internal object MainCommand : Runnable {
-    @Parameters(
-        paramLabel = "INCLUDE",
-        description = ["Which patches to include. If none is specified, all compatible patches will be included"]
-    )
-    internal var includedPatches = arrayOf<String>()
-
-    @Option(names = ["-p", "--patches"], description = ["One or more bundles of patches"])
-    internal var patchBundles = arrayOf<String>()
-
-    @Option(names = ["-t", "--temp-dir"], description = ["Temporal resource cache directory"])
-    internal var cacheDirectory = "revanced-cache"
-
-    @Option(names = ["-r", "--resource-patcher"], description = ["Disable patching resources"])
-    internal var disableResourcePatching: Boolean = false
-
-    @Option(
-        names = ["-c", "--clean"],
-        description = ["Clean the temporal resource cache directory. This will be done anyways when running the patcher"]
-    )
-    internal var clean: Boolean = false
-
-    @Option(names = ["-l", "--list"], description = ["List patches only"])
-    internal var listOnly: Boolean = false
-
-    @Option(names = ["-s", "--signature-checker"], description = ["Check signatures of all patches"])
-    internal var signatureCheck: Boolean = false
-
-    @Option(names = ["-m", "--merge"], description = ["One or more dex file containers to merge"])
-    internal var mergeFiles = listOf<File>()
-
-    @Option(names = ["-a", "--apk"], description = ["Input file to be patched"], required = true)
-    internal lateinit var inputFile: File
-
-    @Option(names = ["-o", "--out"], description = ["Output file path"], required = true)
-    internal lateinit var outputPath: String
-
-    @Option(names = ["-d", "--deploy-on"], description = ["If specified, deploy to adb device with given name"])
-    internal var deploy: String? = null
-
-    @Option(names = ["-b", "--debugging"], description = ["Disable patch version compatibility"])
-    internal var debugging: Boolean = false
-
-    override fun run() {
-        if (listOnly) {
-            for (patchBundlePath in patchBundles) for (it in JarPatchBundle(patchBundlePath).loadPatches()) {
-
-                // TODO: adjust extension methods to be able to do this
-                val name = (it.annotations.find { it is Name } as? Name)?.name ?: it.simpleName
-                println(
-                    "[available] $name"
-                )
-            }
-            return
-        }
-
-        val patcher = app.revanced.patcher.Patcher(PatcherOptions(inputFile, cacheDirectory, !disableResourcePatching))
-
-        if (signatureCheck) {
-            patcher.addPatchesFiltered()
-            Signature.checkSignatures(patcher)
-            return
-        }
-
-        val outputFile = File(outputPath)
-
-        var adb: Adb? = null
-        deploy?.let {
-            adb = Adb(
-                outputFile, patcher.packageName, deploy!!
-            )
-        }
-
-        Patcher.start(patcher)
-
-        if (clean) File(cacheDirectory).deleteRecursively()
-
-        adb?.deploy()
-
-        if (clean) outputFile.delete()
-    }
-}

src/main/kotlin/app/revanced/cli/Patcher.kt

@@ -1,55 +0,0 @@
-package app.revanced.cli
-
-import app.revanced.utils.filesystem.FileSystemUtils
-import app.revanced.utils.patcher.addPatchesFiltered
-import app.revanced.utils.patcher.applyPatchesPrint
-import app.revanced.utils.patcher.mergeFiles
-import app.revanced.utils.signing.Signer
-import java.io.File
-import java.io.FileFilter
-
-internal class Patcher {
-    internal companion object {
-        internal fun start(patcher: app.revanced.patcher.Patcher) {
-            // merge files like necessary integrations
-            patcher.mergeFiles()
-            // add patches, but filter incompatible or excluded patches
-            patcher.addPatchesFiltered(includeFilter = MainCommand.includedPatches.isNotEmpty())
-            // apply patches
-            patcher.applyPatchesPrint()
-
-            // write output file
-            val outFile = File(MainCommand.outputPath)
-            if (outFile.exists()) outFile.delete()
-            MainCommand.inputFile.copyTo(outFile)
-
-            val zipFileSystem = FileSystemUtils(outFile)
-
-            // replace all dex files
-            for ((name, data) in patcher.save()) {
-                zipFileSystem.replaceFile(name, data.data)
-            }
-
-            if (!MainCommand.disableResourcePatching) {
-                for (file in File(MainCommand.cacheDirectory).resolve("build/").listFiles(FileFilter { it.isDirectory })
-                    ?.first()?.listFiles()!!) {
-                    if (!file.isDirectory) {
-                        zipFileSystem.replaceFile(file.name, file.readBytes())
-                        continue
-                    }
-                    zipFileSystem.replaceDirectory(file)
-                }
-            }
-
-            // finally close the stream
-            zipFileSystem.close()
-
-            // and sign the apk file
-            Signer.signApk(outFile)
-
-            println("[done]")
-        }
-
-
-    }
-}

src/main/kotlin/app/revanced/cli/command/MainCommand.kt

@@ -0,0 +1,109 @@
+package app.revanced.cli.command
+
+import app.revanced.cli.patcher.Patcher
+import app.revanced.cli.signing.Signing
+import app.revanced.patcher.PatcherOptions
+import app.revanced.patcher.extensions.PatchExtensions.patchName
+import app.revanced.patcher.util.patch.implementation.JarPatchBundle
+import app.revanced.utils.adb.Adb
+import picocli.CommandLine.Command
+import picocli.CommandLine.Option
+import java.io.File
+import java.nio.file.Files
+
+@Command(
+    name = "ReVanced-CLI", version = ["1.0.0"], mixinStandardHelpOptions = true,
+)
+internal object MainCommand : Runnable {
+    @Option(names = ["-a", "--apk"], description = ["Input file to be patched"], required = true)
+    lateinit var inputFile: File
+
+    @Option(names = ["-o", "--out"], description = ["Output file path"], required = true)
+    lateinit var outputPath: String
+
+    @Option(
+        names = ["-i", "--include"],
+        description = ["Which patches to include. If none is specified, all compatible default patches will be included"]
+    )
+    var includedPatches = arrayOf<String>()
+
+    @Option(names = ["-r", "--resource-patcher"], description = ["Disable patching resources"])
+    var disableResourcePatching: Boolean = false
+
+    @Option(names = ["--debugging"], description = ["Disable patch version compatibility"])
+    var debugging: Boolean = false
+
+    @Option(names = ["-m", "--merge"], description = ["One or more dex file containers to merge"])
+    var mergeFiles = listOf<File>()
+
+    @Option(names = ["-b", "--bundles"], description = ["One or more bundles of patches"])
+    var patchBundles = arrayOf<String>()
+
+    @Option(names = ["-l", "--list"], description = ["List patches only"])
+    var listOnly: Boolean = false
+
+    @Option(names = ["--install"], description = ["If specified, instead of mounting, install"])
+    var install: Boolean = false
+
+    @Option(names = ["--cn"], description = ["Overwrite the default CN for the signed file"])
+    var cn = "ReVanced"
+
+    @Option(names = ["-p", "--password"], description = ["Overwrite the default password for the signed file"])
+    var password = "ReVanced"
+
+    @Option(names = ["-d", "--deploy-on"], description = ["If specified, deploy to adb device with given name"])
+    var deploy: String? = null
+
+    @Option(names = ["-t", "--temp-dir"], description = ["Temporal resource cache directory"])
+    var cacheDirectory = "revanced-cache"
+
+    @Option(
+        names = ["-c", "--clean"],
+        description = ["Clean the temporal resource cache directory. This will be done anyways when running the patcher"]
+    )
+    var clean: Boolean = false
+
+    @Option(names = ["--sign"], description = ["Sign the apk file"])
+    var signApk: Boolean = false
+
+    override fun run() {
+        if (listOnly) {
+            for (patchBundlePath in patchBundles) for (patch in JarPatchBundle(patchBundlePath).loadPatches()) {
+                println("[available] ${patch.patchName}")
+            }
+            return
+        }
+
+        val patcher = app.revanced.patcher.Patcher(PatcherOptions(inputFile, cacheDirectory, !disableResourcePatching))
+
+        val outputFile = File(outputPath)
+
+        val adb: Adb? = deploy?.let {
+            Adb(outputFile, patcher.data.packageMetadata.packageName, deploy!!, install)
+        }
+
+        val patchedFile = if (signApk) File(cacheDirectory).resolve("raw.apk") else outputFile
+
+        Patcher.start(patcher, patchedFile)
+
+        if (signApk) {
+            Signing.start(
+                patchedFile,
+                outputFile,
+                cn,
+                password,
+            )
+        }
+
+        if (clean) File(cacheDirectory).deleteRecursively()
+
+        adb?.let {
+            println("[deploying]")
+            it.deploy()
+        }
+
+        if (clean && deploy != null) Files.delete(outputFile.toPath())
+
+        println("[done]")
+    }
+}

src/main/kotlin/app/revanced/cli/main/Main.kt

@@ -1,5 +1,6 @@
-package app.revanced.cli
+package app.revanced.cli.main
 
+import app.revanced.cli.command.MainCommand
 import picocli.CommandLine
 
 internal fun main(args: Array<String>) {

src/main/kotlin/app/revanced/cli/patcher/Patcher.kt

@@ -0,0 +1,41 @@
+package app.revanced.cli.patcher
+
+import app.revanced.cli.command.MainCommand.cacheDirectory
+import app.revanced.cli.command.MainCommand.disableResourcePatching
+import app.revanced.cli.command.MainCommand
+import app.revanced.cli.command.MainCommand.includedPatches
+import app.revanced.utils.filesystem.ZipFileSystemUtils
+import app.revanced.utils.patcher.addPatchesFiltered
+import app.revanced.utils.patcher.applyPatchesVerbose
+import app.revanced.utils.patcher.mergeFiles
+import java.io.File
+import java.nio.file.Files
+
+internal object Patcher {
+    internal fun start(patcher: app.revanced.patcher.Patcher, output: File) {
+        // merge files like necessary integrations
+        patcher.mergeFiles()
+        // add patches, but filter incompatible or excluded patches
+        patcher.addPatchesFiltered(includeFilter = includedPatches.isNotEmpty())
+        // apply patches
+        patcher.applyPatchesVerbose()
+
+        // write output file
+        if (output.exists()) Files.delete(output.toPath())
+        MainCommand.inputFile.copyTo(output)
+
+        ZipFileSystemUtils(output).use { fileSystem ->
+            // replace all dex files
+            val result = patcher.save()
+            result.dexFiles.forEach {
+                fileSystem.write(it.name, it.memoryDataStore.data)
+            }
+
+            // write resources
+            if (!disableResourcePatching) {
+                fileSystem.writePathRecursively(File(cacheDirectory).resolve("build").toPath())
+                fileSystem.uncompress(*result.doNotCompress!!.toTypedArray())
+            }
+        }
+    }
+}

src/main/kotlin/app/revanced/cli/signing/Signing.kt

@@ -0,0 +1,23 @@
+package app.revanced.cli.signing
+
+import app.revanced.cli.command.MainCommand.cacheDirectory
+import app.revanced.utils.signing.Signer
+import app.revanced.utils.signing.align.ZipAligner
+import java.io.File
+
+object Signing {
+    fun start(inputFile: File, outputFile: File, cn: String, password: String) {
+        // align & sign
+        val cacheDirectory = File(cacheDirectory)
+        val alignedOutput = cacheDirectory.resolve("aligned.apk")
+        val signedOutput = cacheDirectory.resolve("signed.apk")
+        ZipAligner.align(inputFile, alignedOutput)
+        Signer(
+            cn,
+            password
+        ).signApk(inputFile, signedOutput)
+
+        // write to output
+        signedOutput.copyTo(outputFile)
+    }
+}