chore(release): 5.0.0-dev.4 [skip ci]

# [5.0.0-dev.4](https://github.com/ReVanced/revanced-cli/compare/v5.0.0-dev.3...v5.0.0-dev.4) (2024-09-17)

### Bug Fixes

* Make patches selectable by using a mutable collection for the selection option ([751fa1d](751fa1d889))
* Make the patch command work without specifying any selection ([ba159a3](ba159a35a9))

### Features

* Show error about no installation device found at the beginning ([3300e6b](3300e6b433))

CHANGELOG.md

@@ -1,3 +1,23 @@
+# [5.0.0-dev.4](https://github.com/ReVanced/revanced-cli/compare/v5.0.0-dev.3...v5.0.0-dev.4) (2024-09-17)
+
+
+### Bug Fixes
+
+* Make patches selectable by using a mutable collection for the selection option ([751fa1d](https://github.com/ReVanced/revanced-cli/commit/751fa1d889f40c51b291116029fd84f2b051f2f0))
+* Make the patch command work without specifying any selection ([ba159a3](https://github.com/ReVanced/revanced-cli/commit/ba159a35a9a99d18a4c1e04128b08ae336a49b3e))
+
+
+### Features
+
+* Show error about no installation device found at the beginning ([3300e6b](https://github.com/ReVanced/revanced-cli/commit/3300e6b4333ed1c4e6785cb82eca9016fc6d4a20))
+
+# [5.0.0-dev.3](https://github.com/ReVanced/revanced-cli/compare/v5.0.0-dev.2...v5.0.0-dev.3) (2024-08-14)
+
+
+### Features
+
+* Simplify option descriptions ([45c998b](https://github.com/ReVanced/revanced-cli/commit/45c998b335b65ac233fece8b804dc7410142691c))
+
 # [5.0.0-dev.2](https://github.com/ReVanced/revanced-cli/compare/v5.0.0-dev.1...v5.0.0-dev.2) (2024-08-14)
 
 

docs/0_prerequisites.md

@@ -4,9 +4,9 @@ To use ReVanced CLI, you will need to fulfill specific requirements.
 
 ## 🤝 Requirements
 
-- Java Runtime Environment 11 ([Azul Zulu JRE](https://www.azul.com/downloads/?version=java-11-lts&package=jdk#zulu) or [OpenJDK](https://jdk.java.net/archive/))
+- Java Runtime Environment 11 ([Azul Zulu JRE](https://www.azul.com/downloads/?version=java-11-lts&package=jre#zulu) or [OpenJDK](https://jdk.java.net/archive/))
 - [Android Debug Bridge (ADB)](https://developer.android.com/studio/command-line/adb) if you want to install the patched APK file on your device
-- An ABI other than ARMv7 such as x86 or x86-64 (or a custom AAPT binary that supports ARMv7)
+- x86 or x86-64 (For [other architectures](https://github.com/ReVanced/revanced-manager/tree/main/android/app/src/main/jniLibs) use the `--custom-aapt2-binary` option)
 
 ## ⏭️ Whats next
 

docs/1_usage.md

@@ -24,7 +24,7 @@ To patch an app using the default list of patches, use the `patch` command:
 java -jar revanced-cli.jar patch -p patches.rvp input.apk
 ```
 
-You can also use multiple files containing patches:
+You can also use multiple RVP files:
 
 ```bash
 java -jar revanced-cli.jar patch -p patches.rvp -b another-patches.rvp input.apk
@@ -91,13 +91,13 @@ For example, to set the options for the patch with the name `Patch name`
 with the key `key1` and `key2` to `value1` and `value2` respectively, use the following command:
 
 ```bash
-java -jar revanced-cli.jar patch -b patches.rvp -e "Patch name" -Okey1=value1 -Okey2=value2 input.apk
+java -jar revanced-cli.jar patch -p patches.rvp -e "Patch name" -Okey1=value1 -Okey2=value2 input.apk
 ```
 
 If you want to set the option value to `null`, you can omit the value:
 
 ```bash
-java -jar revanced-cli.jar patch -b revanced-patches.rvp -i "Patch name" -Okey1 input.apk
+java -jar revanced-cli.jar patch -p patches.rvp -i "Patch name" -Okey1 input.apk
 ```
 
 > [!WARNING]

gradle.properties

@@ -1,4 +1,4 @@
 org.gradle.parallel = true
 org.gradle.caching = true
 kotlin.code.style = official
-version = 5.0.0-dev.2
+version = 5.0.0-dev.4

src/main/kotlin/app/revanced/cli/command/ListCompatibleVersions.kt

@@ -12,14 +12,14 @@ import java.util.logging.Logger
     name = "list-versions",
     description = [
         "List the most common compatible versions of apps that are compatible " +
-            "with the patches in the supplied files containing patches.",
+            "with the patches from RVP files.",
     ],
 )
 internal class ListCompatibleVersions : Runnable {
     private val logger = Logger.getLogger(this::class.java.name)
 
     @CommandLine.Parameters(
-        description = ["One or more paths to files containing patches."],
+        description = ["Paths to RVP files."],
         arity = "1..*",
     )
     private lateinit var patchesFiles: Set<File>

src/main/kotlin/app/revanced/cli/command/ListPatchesCommand.kt

@@ -11,13 +11,13 @@ import app.revanced.patcher.patch.Option as PatchOption
 
 @Command(
     name = "list-patches",
-    description = ["List patches from supplied files containing patches."],
+    description = ["List patches from supplied RVP files."],
 )
 internal object ListPatchesCommand : Runnable {
     private val logger = Logger.getLogger(this::class.java.name)
 
     @Parameters(
-        description = ["One or more paths to files containing patches."],
+        description = ["Paths to RVP files."],
         arity = "1..*",
     )
     private lateinit var patchesFiles: Set<File>
@@ -59,7 +59,7 @@ internal object ListPatchesCommand : Runnable {
 
     @Option(
         names = ["-i", "--index"],
-        description = ["List the index of each patch in relation to the supplied files containing patches."],
+        description = ["List the index of each patch in relation to the supplied RVP files."],
         showDefaultValue = ALWAYS,
     )
     private var withIndex: Boolean = true

src/main/kotlin/app/revanced/cli/command/PatchCommand.kt

@@ -30,7 +30,7 @@ internal object PatchCommand : Runnable {
     private lateinit var spec: CommandSpec
 
     @ArgGroup(multiplicity = "0..*")
-    private lateinit var selection: Set<Selection>
+    private var selection = mutableSetOf<Selection>()
 
     internal class Selection {
         @ArgGroup(exclusive = false, multiplicity = "1")
@@ -50,7 +50,7 @@ internal object PatchCommand : Runnable {
 
                 @CommandLine.Option(
                     names = ["--ei"],
-                    description = ["Index of the patch in the combined list of all supplied files containing patches."],
+                    description = ["Index of the patch in the combined list of the supplied RVP files."],
                     required = true,
                 )
                 internal var index: Int? = null
@@ -82,7 +82,7 @@ internal object PatchCommand : Runnable {
 
                 @CommandLine.Option(
                     names = ["--di"],
-                    description = ["Index of the patch in the combined list of all supplied files containing patches."],
+                    description = ["Index of the patch in the combined list of the supplied RVP files."],
                     required = true,
                 )
                 internal var index: Int? = null
@@ -200,7 +200,7 @@ internal object PatchCommand : Runnable {
 
     @CommandLine.Option(
         names = ["-p", "--patches"],
-        description = ["One or more path to files containing patches."],
+        description = ["One or more path to RVP files."],
         required = true,
     )
     @Suppress("unused")
@@ -245,6 +245,32 @@ internal object PatchCommand : Runnable {
             keyStoreFilePath ?: outputFilePath.parentFile
                 .resolve("${outputFilePath.nameWithoutExtension}.keystore")
 
+        val installer = if (deviceSerial != null) {
+            try {
+                if (mount) {
+                    AdbRootInstaller(deviceSerial)
+                } else {
+                    AdbInstaller(deviceSerial)
+                }
+            } catch (e: DeviceNotFoundException) {
+                if (deviceSerial!!.isNotEmpty()) {
+                    logger.severe(
+                        "Device with serial $deviceSerial not found to install to. " +
+                            "Ensure the device is connected and the serial is correct when using the --install option.",
+                    )
+                } else {
+                    logger.severe(
+                        "No device has been found to install to. " +
+                            "Ensure a device is connected when using the --install option.",
+                    )
+                }
+
+                return
+            }
+        } else {
+            null
+        }
+
         // endregion
 
         // region Load patches
@@ -332,13 +358,7 @@ internal object PatchCommand : Runnable {
             val deviceSerial = it.ifEmpty { null }
 
             runBlocking {
-                val result = if (mount) {
+                when (val result = installer!!.install(Installer.Apk(outputFilePath, packageName))) {
-                    AdbRootInstaller(deviceSerial)
-                } else {
-                    AdbInstaller(deviceSerial)
-                }.install(Installer.Apk(outputFilePath, packageName))
-
-                when (result) {
                     RootInstallerResult.FAILURE -> logger.severe("Failed to mount the patched APK file")
                     is AdbInstallerResult.Failure -> logger.severe(result.exception.toString())
                     else -> logger.info("Installed the patched APK file")
@@ -366,14 +386,14 @@ internal object PatchCommand : Runnable {
         packageVersion: String,
     ): Set<Patch<*>> = buildSet {
         val enabledPatchesByName =
-            selection.asSequence().mapNotNull { it.enabled?.selector?.name }.toSet()
+            selection.mapNotNull { it.enabled?.selector?.name }.toSet()
         val enabledPatchesByIndex =
-            selection.asSequence().mapNotNull { it.enabled?.selector?.index }.toSet()
+            selection.mapNotNull { it.enabled?.selector?.index }.toSet()
 
         val disabledPatches =
-            selection.asSequence().mapNotNull { it.disable?.selector?.name }.toSet()
+            selection.mapNotNull { it.disable?.selector?.name }.toSet()
         val disabledPatchesByIndex =
-            selection.asSequence().mapNotNull { it.disable?.selector?.index }.toSet()
+            selection.mapNotNull { it.disable?.selector?.index }.toSet()
 
         this@filterPatchSelection.withIndex().forEach patchLoop@{ (i, patch) ->
             val patchName = patch.name!!