chore(release): 1.19.4-dev.1 [skip ci]

## [1.19.4-dev.1](https://github.com/ReVanced/revanced-manager/compare/v1.19.3...v1.19.4-dev.1) (2024-03-17)

### Bug Fixes

* Pre-releases changelog being shown ([#1767](https://github.com/ReVanced/revanced-manager/issues/1767)) ([add49e1](add49e14fb))

.github/workflows/build_pull_request.yml

@@ -107,7 +107,7 @@ jobs:
             - App flavor: ${{ inputs.app-flavour }}
 
       - name: Upload
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           if-no-files-found: error
           name: revanced-manager-(${{ env.COMMIT_HASH }}-${{ inputs.pr-number }}-${{ inputs.app-flavour }})

.github/workflows/open_pull_request.yml

@@ -25,3 +25,4 @@ jobs:
           pr_body: |
             This pull request will ${{ env.MESSAGE }}.
           pr_draft: true
+          github_token: ${{ secrets.REPOSITORY_PUSH_ACCESS }}

.github/workflows/sync_crowdin.yml

@@ -2,9 +2,13 @@ name: Sync Crowdin
 
 on:
   workflow_dispatch:
+  schedule: 
+    - cron: 00 12 * * 1
   push:
-    branches:
+    paths:
-      - dev
+      - assets/i18n/*.json
+      - assets/i18n/*.dart
+      - .github/workflows/sync_crowdin.yml
 
 jobs:
   sync:
@@ -16,7 +20,7 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Set up Dart
+      - name: Setup Dart
         uses: dart-lang/setup-dart@v1
 
       - name: Sync translations from Crowdin
@@ -32,15 +36,17 @@ jobs:
           pull_request_body: "Sync translations from [crowdin.com/project/revanced](https://crowdin.com/project/revanced)"
           pull_request_base_branch_name: "dev"
           commit_message: "chore: Sync translations"
+          github_user_name: revanced-bot
+          github_user_email: github@revanced.app
         env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          GITHUB_TOKEN: ${{ secrets.REPOSITORY_PUSH_ACCESS }}
           CROWDIN_PROJECT_ID: ${{ secrets.CROWDIN_PROJECT_ID }}
           CROWDIN_PERSONAL_TOKEN: ${{ secrets.CROWDIN_PERSONAL_TOKEN }}
 
       - name: Remove empty values from JSON
         run: |
           cd assets/i18n
-          sudo chmod 777 *
+          sudo chmod 777 *.json
           dart nuke.dart >> $GITHUB_STEP_SUMMARY
 
       - name: Commit translations
@@ -51,5 +57,3 @@ jobs:
           git add assets/i18n/*.json
           git commit -m "chore: Remove empty values from JSON" assets/i18n/*.json
           git push origin HEAD:feat/translations
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/update_documentation.yml

@@ -11,7 +11,7 @@ jobs:
     name: Dispatch event to documentation repository
     if: github.ref == 'refs/heads/main'
     steps:
-      - uses: peter-evans/repository-dispatch@v2
+      - uses: peter-evans/repository-dispatch@v3
         with:
           token: ${{ secrets.DOCUMENTATION_REPO_ACCESS_TOKEN  }}
           repository: revanced/revanced-documentation

SECURITY.md

@@ -70,8 +70,8 @@ If a vulnerability is confirmed and accepted, you can join our [Discord](https:/
 
 ### ⏳ Supported Versions
 
-| Version                                                                                                  | Branch      | Supported          |
+| Version                                                                                                                                 | Branch      | Supported          |
-| -------------------------------------------------------------------------------------------------------- | ----------- | ------------------ |
+| --------------------------------------------------------------------------------------------------------------------------------------- | ----------- | ------------------ |
-| ![GitHub Release](https://img.shields.io/github/v/release/ReVanced/revanced-manager?style=for-the-badge) | main        | :white_check_mark: |
+| ![Latest stable release](https://img.shields.io/github/v/release/ReVanced/revanced-manager?style=for-the-badge "Latest stable release") | main        | :white_check_mark: |
-| ![Static Badge](https://img.shields.io/badge/version-latest-brightgreen?style=for-the-badge)             | dev         | :white_check_mark: |
+| ![Latest version](https://img.shields.io/badge/version-latest-brightgreen?style=for-the-badge "Latest version")                         | dev         | :white_check_mark: |
-| ![Static Badge](https://img.shields.io/badge/version-latest-brightgreen?style=for-the-badge)             | compose-dev | :white_check_mark: |
+| ![Latest version](https://img.shields.io/badge/version-latest-brightgreen?style=for-the-badge "Latest version")                         | compose-dev | :white_check_mark: |

android/app/build.gradle

@@ -113,9 +113,8 @@ flutter {
 }
 
 dependencies {
-    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.9.22"
+    implementation("org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.9.22")
 
-    // ReVanced
+    implementation("app.revanced:revanced-patcher:19.3.1")
-    implementation "app.revanced:revanced-patcher:19.3.1"
+    implementation("app.revanced:revanced-library:2.2.1")
-    implementation "app.revanced:revanced-library:2.1.0"
 }

android/app/src/main/kotlin/app/revanced/manager/flutter/MainActivity.kt

@@ -9,7 +9,6 @@ import android.os.Handler
 import android.os.Looper
 import app.revanced.library.ApkUtils
 import app.revanced.library.ApkUtils.applyTo
-import app.revanced.library.ApkUtils.sign
 import app.revanced.manager.flutter.utils.Aapt
 import app.revanced.manager.flutter.utils.packageInstaller.InstallerReceiver
 import app.revanced.manager.flutter.utils.packageInstaller.UninstallerReceiver
@@ -339,16 +338,15 @@ class MainActivity : FlutterActivity() {
                     patcher.get()
                 }
 
-                inFile.copyTo(outFile)
+                if (cancel(patcher::close)) return@Thread
+
+                patcherResult.applyTo(inFile)
 
                 if (cancel(patcher::close)) return@Thread
 
-                patcherResult.applyTo(outFile)
+                ApkUtils.sign(
-
+                    inFile,
-                if (cancel(patcher::close)) return@Thread
+                    outFile,
-                updateProgress(0.8, "Signing...", "")
-
-                outFile.sign(
                     ApkUtils.SigningOptions(
                         keyStoreFile,
                         keystorePassword,

docs/2_4_settings.md

@@ -9,32 +9,32 @@ Learn how to configure ReVanced Manager.
   By default, you can not change the patch selection and the default selection is used. Enabling this will allow you to change the patch selection.
 
   > ⚠️ Warning  
-  > Changing the selection may cause cause unexpected issues. Unless you know what you are doing, it is recommended to keep this disabled.
+  > Changing the selection may cause unexpected issues. Unless you know what you are doing, it is recommended to keep this disabled.
 
 - ### 📦 Require suggested app version
 
-  By default, ReVanced Manager allows you to patch an app if the suggested version to patch matches the app you selected. Disabling this will allow you to patch an app even if the suggested version does not match the app you selected.
+  By default, ReVanced Manager allows you to patch an app if the suggested version to patch matches the version of the app you selected. Disabling this will allow you to patch an app even if the suggested version does not match the version of the app you selected.
 
   > ⚠️ Warning  
   > Patches are more likely to fail on versions that are not suggested by ReVanced Manager. Unless you know what you are doing, it is recommended to keep this enabled.
 
 - ### ✅ Version compatibility check
 
-  By default, ReVanced Manager allows you to select patches that are not compatible with the version of the app you selected. Disabling this will allow you to select patches that are not compatible with the app version you selected.
+  By default, ReVanced Manager does not allow you to select patches that are not compatible with the version of the app you selected. Disabling this will allow you to select patches that are not compatible with the version of the app you selected.
 
   > ⚠️ Warning  
   > Patches are more likely to fail on versions they are not compatible with. Unless you know what you are doing, it is recommended to keep this enabled.
 
 - ### 🧑‍🔬 Show universal patches
 
-  By default, ReVanced Manager only shows patches that are compatible with specifc apps. Enabling this will show patches that are intended to work on all apps.
+  By default, ReVanced Manager only shows patches that are compatible with specific apps. Enabling this will show patches that are intended to work on all apps.
 
   > ⚠️ Warning  
-  > Patches that are intended to work on all apps may not work on all apps. Unless you know what you are doing, it is recommended to keep this disabled.
+  > Patches that are intended to may not work on all apps. Unless you know what you are doing, it is recommended to keep this disabled.
 
 - ### 🔗 API URL
 
-  Configure the API URL to use. The API is used to download updates and patches.
+  Configure the API URL to use. The API is used to download patches and updates.
 
 - ### 🧬 Use alternative source
 

lib/services/github_api.dart

@@ -85,6 +85,9 @@ class GithubAPI {
         updates++;
       }
       for (int i = 1; i < updates; i++) {
+        if (response.data[i]['prerelease']) {
+          continue;
+        }
         releases.update(
           'body',
           (value) =>

lib/services/patcher_api.dart

@@ -171,7 +171,10 @@ class PatcherAPI {
     if (integrationsFile != null) {
       _dataDir.createSync();
       _tmpDir.createSync();
-      final Directory workDir = _tmpDir.createTempSync('tmp-');
+      final Directory workDir = await _tmpDir.createTemp('tmp-');
+
+      final File inApkFile = File('${workDir.path}/in.apk');
+      await File(apkFilePath).copy(inApkFile.path);
 
       outFile = File('${workDir.path}/out.apk');
 
@@ -182,7 +185,7 @@ class PatcherAPI {
         await patcherChannel.invokeMethod(
           'runPatcher',
           {
-            'inFilePath': apkFilePath,
+            'inFilePath': inApkFile.path,
             'outFilePath': outFile!.path,
             'integrationsPath': integrationsFile.path,
             'selectedPatches': selectedPatches.map((p) => p.name).toList(),
@@ -297,6 +300,18 @@ class PatcherAPI {
     );
     bool cleanInstall = false;
     final bool isFixable = statusCode == 4 || statusCode == 5;
+
+    var description = t['installErrorDialog.${statusValue}_description'];
+    if (statusCode == 2) {
+      description = description(
+        packageName: statusCode == 2
+            ? {
+                'packageName': status['otherPackageName'],
+              }
+            : null,
+      );
+    }
+
     await showDialog(
       context: _managerAPI.ctx!,
       builder: (context) => AlertDialog(
@@ -306,15 +321,7 @@ class PatcherAPI {
           crossAxisAlignment: CrossAxisAlignment.start,
           mainAxisSize: MainAxisSize.min,
           children: [
-            Text(
+            Text(description),
-              t['installErrorDialog.${statusValue}_description'](
-                packageName: statusCode == 2
-                    ? {
-                        'packageName': status['otherPackageName'],
-                      }
-                    : null,
-              ),
-            ),
           ],
         ),
         actions: (status == null)

lib/ui/views/app_selector/app_selector_view.dart

@@ -78,7 +78,7 @@ class _AppSelectorViewState extends State<AppSelectorView> {
                         ),
                       ),
                     )
-                  : model.allApps.isEmpty
+                  : model.allApps.isEmpty && model.apps.isEmpty
                       ? const AppSkeletonLoader()
                       : Padding(
                           padding: const EdgeInsets.symmetric(horizontal: 12.0)

lib/ui/views/app_selector/app_selector_viewmodel.dart

@@ -54,7 +54,7 @@ class AppSelectorViewModel extends BaseViewModel {
         .toSet()
         .where((name) => !apps.any((app) => app.packageName == name))
         .toList();
-    noApps = allApps.isEmpty;
+    noApps = allApps.isEmpty && apps.isEmpty;
     return allApps;
   }
 

package-lock.json

@@ -5,7 +5,7 @@
   "packages": {
     "": {
       "devDependencies": {
-        "@droidsolutions-oss/semantic-release-update-file": "^1.3.2",
+        "@droidsolutions-oss/semantic-release-update-file": "^1.4.0-beta.1",
         "@saithodev/semantic-release-backmerge": "^4.0.1",
         "@semantic-release/changelog": "^6.0.3",
         "@semantic-release/exec": "^6.0.3",
@@ -60,9 +60,9 @@
       }
     },
     "node_modules/@droidsolutions-oss/semantic-release-update-file": {
-      "version": "1.3.2",
+      "version": "1.4.0-beta.1",
-      "resolved": "https://registry.npmjs.org/@droidsolutions-oss/semantic-release-update-file/-/semantic-release-update-file-1.3.2.tgz",
+      "resolved": "https://registry.npmjs.org/@droidsolutions-oss/semantic-release-update-file/-/semantic-release-update-file-1.4.0-beta.1.tgz",
-      "integrity": "sha512-ahV0OWiEUf20e7lLH3gnBLF1SfRNPN99MeaLVaFX6jT3DegTLzkVPeY2CZWa+K4tAXBALc29Bq/kzjv8PAXFGw==",
+      "integrity": "sha512-CdqG3vIceWFBmwz0qcY0NdqaE+TGNuhhbgFXHIj/M1fYAD1lQ4QyGEaoD3d4F4ZHYsBqR0HrHNMTG4bycBRKNw==",
       "dev": true,
       "dependencies": {
         "aggregate-error": "^3.1.0",

package.json

@@ -1,6 +1,6 @@
 {
   "devDependencies": {
-    "@droidsolutions-oss/semantic-release-update-file": "^1.3.2",
+    "@droidsolutions-oss/semantic-release-update-file": "^1.4.0-beta.1",
     "@saithodev/semantic-release-backmerge": "^4.0.1",
     "@semantic-release/changelog": "^6.0.3",
     "@semantic-release/exec": "^6.0.3",

pubspec.lock

@@ -459,10 +459,10 @@ packages:
     dependency: "direct main"
     description:
       name: google_fonts
-      sha256: "5b1726fee554d1cc9db1baef8061b126567ff0a1140a03ed7de936e62f2ab98b"
+      sha256: b1ac0fe2832c9cc95e5e88b57d627c5e68c223b9657f4b96e1487aa9098c7b82
       url: "https://pub.dev"
     source: hosted
-    version: "6.2.0"
+    version: "6.2.1"
   graphs:
     dependency: transitive
     description:
@@ -1361,4 +1361,4 @@ packages:
     version: "3.1.2"
 sdks:
   dart: ">=3.3.0 <4.0.0"
-  flutter: ">=3.19.0"
+  flutter: ">=3.19.2"

pubspec.yaml

@@ -4,7 +4,7 @@ homepage: https://github.com/ReVanced/revanced-manager
 
 publish_to: 'none'
 
-version: 1.19.1+101800002
+version: 1.19.4-dev.1+101800007
 
 environment:
   sdk: '>=3.0.0 <4.0.0'
@@ -37,7 +37,7 @@ dependencies:
   flutter_markdown: ^0.6.14
   fluttertoast: ^8.2.4
   font_awesome_flutter: ^10.4.0
-  google_fonts: ^6.1.0
+  google_fonts: ^6.2.1
   injectable: ^2.1.1
   intl: ^0.18.0
   json_annotation: ^4.8.1