Move emulator settings

src/analyzer/main.cpp

@@ -95,12 +95,12 @@ namespace
 			return;
 		}
 
-		const emulator_settings settings{
+		emulator_settings settings{
 			.application = argv[0],
 			.arguments = parse_arguments(argv, argc),
 		};
 
-		windows_emulator win_emu{settings};
+		windows_emulator win_emu{std::move(settings)};
 
 		(void)&watch_system_objects;
 		watch_system_objects(win_emu);

src/fuzzer/main.cpp

@@ -144,11 +144,11 @@ namespace
 
 	void run(const std::string_view application)
 	{
-		const emulator_settings settings{
+		emulator_settings settings{
 			.application = application,
 		};
 
-		windows_emulator win_emu{settings};
+		windows_emulator win_emu{std::move(settings)};
 
 		forward_emulator(win_emu);
 		run_fuzzer(win_emu);

src/windows-emulator-test/emulation_test_utils.hpp

@@ -20,10 +20,10 @@
 
 namespace test
 {
-	inline windows_emulator create_sample_emulator(emulator_settings& settings)
+	inline windows_emulator create_sample_emulator(emulator_settings settings)
 	{
 		settings.application = "./test-sample.exe";
-		return windows_emulator{settings};
+		return windows_emulator{std::move(settings)};
 	}
 
 	inline windows_emulator create_sample_emulator()
@@ -34,6 +34,6 @@ namespace test
 			.use_relative_time = true,
 		};
 
-		return create_sample_emulator(settings);
+		return create_sample_emulator(std::move(settings));
 	}
 }

src/windows-emulator/windows_emulator.cpp

@@ -716,7 +716,7 @@ std::unique_ptr<x64_emulator> create_default_x64_emulator()
 	return unicorn::create_x64_emulator();
 }
 
-windows_emulator::windows_emulator(const emulator_settings& settings,
+windows_emulator::windows_emulator(emulator_settings settings,
                                    std::unique_ptr<x64_emulator> emu)
 	: windows_emulator(std::move(emu))
 {

src/windows-emulator/windows_emulator.hpp

@@ -26,7 +26,7 @@ class windows_emulator
 {
 public:
 	windows_emulator(std::unique_ptr<x64_emulator> emu = create_default_x64_emulator());
-	windows_emulator(const emulator_settings& settings,
+	windows_emulator(emulator_settings settings,
 	                 std::unique_ptr<x64_emulator> emu = create_default_x64_emulator());
 
 	windows_emulator(windows_emulator&&) = delete;