chore(release): 1.0.0-dev.34 [skip ci]

# @revanced/discord-bot [1.0.0-dev.34](https://github.com/revanced/revanced-helper/compare/@revanced/discord-bot@1.0.0-dev.33...@revanced/discord-bot@1.0.0-dev.34) (2024-10-17)

### Bug Fixes

* **bots/discord:** attempt to fix stuck sticky message timeouts ([3ed5bd1](3ed5bd11ac))
* **bots/discord:** fix reload not working ([11582d5](11582d5034))

### Features

* **bots/discord:** add default durations for moderation commands ([27d3b39](27d3b39209))
* **bots/discord:** cure on every event ([8ff6086](8ff6086028))

apis/websocket/package.json

@@ -28,13 +28,13 @@
   "homepage": "https://github.com/revanced/revanced-helper#readme",
   "dependencies": {
     "@revanced/bot-shared": "workspace:*",
-    "@sapphire/async-queue": "^1.5.2",
+    "@sapphire/async-queue": "^1.5.3",
     "chalk": "^5.3.0",
-    "tesseract.js": "^5.1.0",
-    "ws": "^8.17.1"
+    "tesseract.js": "^5.1.1",
+    "ws": "^8.18.0"
   },
   "devDependencies": {
-    "@types/ws": "^8.5.10",
+    "@types/ws": "^8.5.12",
     "typed-emitter": "^2.1.0"
   }
-}
+}

bots/discord/CHANGELOG.md

@@ -1,3 +1,91 @@
+# @revanced/discord-bot [1.0.0-dev.34](https://github.com/revanced/revanced-helper/compare/@revanced/discord-bot@1.0.0-dev.33...@revanced/discord-bot@1.0.0-dev.34) (2024-10-17)
+
+
+### Bug Fixes
+
+* **bots/discord:** attempt to fix stuck sticky message timeouts ([3ed5bd1](https://github.com/revanced/revanced-helper/commit/3ed5bd11acc3b4fbd57b0d632c68eb9f77365b8a))
+* **bots/discord:** fix reload not working ([11582d5](https://github.com/revanced/revanced-helper/commit/11582d50345cae9fb645a65ca4e621596de6a408))
+
+
+### Features
+
+* **bots/discord:** add default durations for moderation commands ([27d3b39](https://github.com/revanced/revanced-helper/commit/27d3b392092141a1e3b4b0298131ff7817458dc1))
+* **bots/discord:** cure on every event ([8ff6086](https://github.com/revanced/revanced-helper/commit/8ff6086028132cc4b49ee60846e8d6ef909f5a89))
+
+# @revanced/discord-bot [1.0.0-dev.33](https://github.com/revanced/revanced-helper/compare/@revanced/discord-bot@1.0.0-dev.32...@revanced/discord-bot@1.0.0-dev.33) (2024-09-25)
+
+
+### Features
+
+* **bots/discord:** add trigger to context for eval ([b5f4097](https://github.com/revanced/revanced-helper/commit/b5f40975386677ffff343c42f8ffac21f847a0b7))
+
+# @revanced/discord-bot [1.0.0-dev.32](https://github.com/revanced/revanced-helper/compare/@revanced/discord-bot@1.0.0-dev.31...@revanced/discord-bot@1.0.0-dev.32) (2024-09-25)
+
+
+### Bug Fixes
+
+* **bots/discord:** contextify object before sandboxing ([062735f](https://github.com/revanced/revanced-helper/commit/062735f6d552890404d6192244c51a11b0709580))
+
+# @revanced/discord-bot [1.0.0-dev.31](https://github.com/revanced/revanced-helper/compare/@revanced/discord-bot@1.0.0-dev.30...@revanced/discord-bot@1.0.0-dev.31) (2024-09-25)
+
+
+### Bug Fixes
+
+* **bots/discord:** persist changes in context for eval command ([5b4965d](https://github.com/revanced/revanced-helper/commit/5b4965dcc7285676b2b3b6756c249bd56eaf8485))
+
+# @revanced/discord-bot [1.0.0-dev.30](https://github.com/revanced/revanced-helper/compare/@revanced/discord-bot@1.0.0-dev.29...@revanced/discord-bot@1.0.0-dev.30) (2024-09-24)
+
+
+### Features
+
+* **bots/discord:** improve admin commands ([0346741](https://github.com/revanced/revanced-helper/commit/03467411882b8598e2c06f389a09ef2e201bb43f))
+
+# @revanced/discord-bot [1.0.0-dev.29](https://github.com/revanced/revanced-helper/compare/@revanced/discord-bot@1.0.0-dev.28...@revanced/discord-bot@1.0.0-dev.29) (2024-09-21)
+
+
+### Bug Fixes
+
+* **bots/discord:** fix get response logic ([3261294](https://github.com/revanced/revanced-helper/commit/3261294822b0a9faec094536ed5be2d3e1d5e17b))
+
+# @revanced/discord-bot [1.0.0-dev.28](https://github.com/revanced/revanced-helper/compare/@revanced/discord-bot@1.0.0-dev.27...@revanced/discord-bot@1.0.0-dev.28) (2024-09-20)
+
+
+### Bug Fixes
+
+* **bots/discord:** don't refresh timer if force timer is active for sticky messages ([4abac0c](https://github.com/revanced/revanced-helper/commit/4abac0c890c0548e14cb56723cae919353a8e726))
+* **bots/discord:** filter out text triggers correctly from image-only scans ([8c0dd67](https://github.com/revanced/revanced-helper/commit/8c0dd67d03d5a1747993da08a5bf82a39de43789))
+
+# @revanced/discord-bot [1.0.0-dev.27](https://github.com/revanced/revanced-helper/compare/@revanced/discord-bot@1.0.0-dev.26...@revanced/discord-bot@1.0.0-dev.27) (2024-09-05)
+
+
+### Bug Fixes
+
+* **bots/discord:** correct permission check logic ([dd8872c](https://github.com/revanced/revanced-helper/commit/dd8872c027c7e7e1a00f38d659b4d6e79274238c))
+* **bots/discord:** give only removed roles for role presets ([522ad28](https://github.com/revanced/revanced-helper/commit/522ad28fd83565e9ca411dbce86c8447574288fd))
+* **bots/discord:** replace duration parser with a library ([94c4fed](https://github.com/revanced/revanced-helper/commit/94c4fedc06e20051e4123508e3134b97eb84782a))
+
+# @revanced/discord-bot [1.0.0-dev.27](https://github.com/revanced/revanced-helper/compare/@revanced/discord-bot@1.0.0-dev.26...@revanced/discord-bot@1.0.0-dev.27) (2024-08-23)
+
+
+### Bug Fixes
+
+* **bots/discord:** give only removed roles for role presets ([522ad28](https://github.com/revanced/revanced-helper/commit/522ad28fd83565e9ca411dbce86c8447574288fd))
+* **bots/discord:** replace duration parser with a library ([94c4fed](https://github.com/revanced/revanced-helper/commit/94c4fedc06e20051e4123508e3134b97eb84782a))
+
+# @revanced/discord-bot [1.0.0-dev.26](https://github.com/revanced/revanced-helper/compare/@revanced/discord-bot@1.0.0-dev.25...@revanced/discord-bot@1.0.0-dev.26) (2024-08-15)
+
+
+### Bug Fixes
+
+* **bots/discord:** correct timer active condition for sticky messages ([96065ff](https://github.com/revanced/revanced-helper/commit/96065ff17584ff99a56ca5008327863ca5a7852b))
+
+# @revanced/discord-bot [1.0.0-dev.25](https://github.com/revanced/revanced-helper/compare/@revanced/discord-bot@1.0.0-dev.24...@revanced/discord-bot@1.0.0-dev.25) (2024-08-15)
+
+
+### Bug Fixes
+
+* **bots/discord:** allow access to `context` in `/eval` and await result ([99f65f0](https://github.com/revanced/revanced-helper/commit/99f65f07f5f8830c6e8ea4ae171e986af4d3f1f6))
+
 # @revanced/discord-bot [1.0.0-dev.24](https://github.com/revanced/revanced-helper/compare/@revanced/discord-bot@1.0.0-dev.23...@revanced/discord-bot@1.0.0-dev.24) (2024-08-14)
 
 

bots/discord/package.json

@@ -2,7 +2,7 @@
   "name": "@revanced/discord-bot",
   "type": "module",
   "private": true,
-  "version": "1.0.0-dev.24",
+  "version": "1.0.0-dev.34",
   "description": "🤖 Discord bot assisting ReVanced",
   "main": "src/index.ts",
   "scripts": {
@@ -28,18 +28,19 @@
   },
   "homepage": "https://github.com/revanced/revanced-helper#readme",
   "dependencies": {
-    "@discordjs/builders": "^1.8.2",
-    "@discordjs/rest": "^2.3.0",
+    "@discordjs/builders": "^1.9.0",
+    "@discordjs/rest": "^2.4.0",
     "@revanced/bot-api": "workspace:*",
     "@revanced/bot-shared": "workspace:*",
     "chalk": "^5.3.0",
-    "decancer": "^3.2.3",
-    "discord.js": "^14.15.3",
-    "drizzle-orm": "^0.31.4"
+    "decancer": "^3.2.4",
+    "discord.js": "^14.16.3",
+    "drizzle-orm": "^0.31.4",
+    "parse-duration": "^1.1.0"
   },
   "devDependencies": {
     "@libsql/client": "^0.7.0",
-    "discord-api-types": "^0.37.92",
+    "discord-api-types": "^0.37.102",
     "drizzle-kit": "^0.22.8"
   }
 }

bots/discord/src/classes/Command.ts

@@ -373,7 +373,7 @@ export default class Command<
             memberRequirementsForUsers = 'pass',
         } = this.requirements
 
-        const member = this.isGuildSpecific() ? null : (executor as GuildMember)
+        const member = this.isGuildSpecific() ? (executor as GuildMember) : null
         const boolDefaultCondition = defaultCondition !== 'fail'
         const boolMemberRequirementsForUsers = memberRequirementsForUsers !== 'fail'
 

bots/discord/src/commands/admin/eval.ts

@@ -1,8 +1,12 @@
+import { unlinkSync, writeFileSync } from 'fs'
+import { join } from 'path'
 import { inspect } from 'util'
+import { createContext, runInContext } from 'vm'
 import { ApplicationCommandOptionType } from 'discord.js'
 
 import { AdminCommand } from '$/classes/Command'
 import { createSuccessEmbed } from '$/utils/discord/embeds'
+import { parseDuration } from '$/utils/duration'
 
 export default new AdminCommand({
     name: 'eval',
@@ -18,23 +22,74 @@ export default new AdminCommand({
             type: ApplicationCommandOptionType.Boolean,
             required: false,
         },
+        ['inspect-depth']: {
+            description: 'How many times to recurse while formatting the object (default: 1)',
+            type: ApplicationCommandOptionType.Integer,
+            required: false,
+        },
+        timeout: {
+            description: 'Timeout for the evaluation (default: 10s)',
+            type: ApplicationCommandOptionType.String,
+            required: false,
+        },
     },
-    async execute(_, trigger, { code, 'show-hidden': showHidden }) {
+    async execute(context, trigger, { code, 'show-hidden': showHidden, timeout, ['inspect-depth']: inspectDepth }) {
+        const currentToken = context.discord.client.token
+        const currentEnvToken = process.env['DISCORD_TOKEN']
+        context.discord.client.token = null
+        process.env['DISCORD_TOKEN'] = undefined
+
+        // This allows developers to access and modify the context object to apply changes
+        // to the bot while the bot is running, minus malicious actors getting the token to perform malicious actions
+        const output = await runInContext(
+            code,
+            createContext({
+                ...globalThis,
+                context,
+                trigger,
+            }),
+            {
+                timeout: parseDuration(timeout ?? '10s'),
+                filename: 'eval',
+                displayErrors: true,
+            },
+        )
+
+        context.discord.client.token = currentToken
+        process.env['DISCORD_TOKEN'] = currentEnvToken
+
+        const inspectedOutput = inspect(output, {
+            depth: inspectDepth ?? 1,
+            showHidden,
+            getters: showHidden,
+            numericSeparator: true,
+            showProxy: showHidden,
+        })
+
+        const embed = createSuccessEmbed('Evaluate', `\`\`\`js\n${code}\`\`\``)
+        const files: string[] = []
+        const filepath = join(Bun.main, '..', `output-eval-${Date.now()}.js`)
+
+        if (inspectedOutput.length > 1000) {
+            writeFileSync(filepath, inspectedOutput)
+            files.push(filepath)
+
+            embed.addFields({
+                name: 'Result',
+                value: '```js\n// (output too long, file uploaded)```',
+            })
+        } else
+            embed.addFields({
+                name: 'Result',
+                value: `\`\`\`js\n${inspectedOutput}\`\`\``,
+            })
+
         await trigger.reply({
             ephemeral: true,
-            embeds: [
-                createSuccessEmbed('Evaluate', `\`\`\`js\n${code}\`\`\``).addFields({
-                    name: 'Result',
-                    // biome-ignore lint/security/noGlobalEval: This is fine as it's an admin command
-                    value: `\`\`\`js\n${inspect(eval(code), {
-                        depth: 1,
-                        showHidden,
-                        getters: true,
-                        numericSeparator: true,
-                        showProxy: true,
-                    })}\`\`\``,
-                }),
-            ],
+            embeds: [embed],
+            files,
         })
+
+        if (files.length) unlinkSync(filepath)
     },
 })

bots/discord/src/commands/admin/exception-test.ts

@@ -11,7 +11,10 @@ export default new AdminCommand({
             description: 'The type of exception to throw',
             type: ApplicationCommandOptionType.String,
             required: true,
-            choices: Object.keys(CommandErrorType).map(k => ({ name: k, value: k })),
+            choices: [
+                { name: 'Process', value: 'Process' },
+                ...Object.keys(CommandErrorType).map(k => ({ name: k, value: k })),
+            ],
         },
     },
     async execute(_, __, { type }) {

bots/discord/src/commands/admin/reload.ts

@@ -1,14 +1,14 @@
 import { AdminCommand } from '$/classes/Command'
-import { join, dirname } from 'path'
-
-import type { Config } from 'config.schema'
 
 export default new AdminCommand({
     name: 'reload',
     description: 'Reload configuration',
     async execute(context, trigger) {
         const { api, logger, discord } = context
-        context.config = ((await import(join(dirname(Bun.main), '..', 'config.js'))) as { default: Config }).default
+        logger.info(`Reload triggered by ${context.executor.tag} (${context.executor.id})`)
+
+        logger.debug('Invalidating previous config...')
+        context.config.invalidate()
 
         if ('deferReply' in trigger) await trigger.deferReply({ ephemeral: true })
 
@@ -23,7 +23,7 @@ export default new AdminCommand({
         api.client.disconnect(true)
         api.disconnectCount = 0
         api.intentionallyDisconnecting = false
-        await api.client.connect()
+        api.client.connect()
 
         logger.info('Reinitializing Discord client to reload configuration...')
         await discord.client.destroy()
@@ -32,6 +32,6 @@ export default new AdminCommand({
         await discord.client.login(process.env['DISCORD_TOKEN'])
 
         // @ts-expect-error: TypeScript dum
-        await trigger[('deferReply' in trigger ? 'editReply' : 'reply')]({ content: 'Reloaded configuration' })
+        await trigger['deferReply' in trigger ? 'editReply' : 'reply']({ content: 'Reloaded configuration' })
     },
 })

bots/discord/src/commands/moderation/ban.ts

@@ -18,13 +18,14 @@ export default new ModerationCommand({
             required: false,
             type: ModerationCommand.OptionType.String,
         },
-        dmd: {
-            description: 'Duration to delete messages (must be from 0 to 7 days)',
+        dmt: {
+            description:
+                'Time duration to delete messages (default time unit is days, must be from 0s to 7d, default value is 0s)',
             required: false,
             type: ModerationCommand.OptionType.String,
         },
     },
-    async execute({ logger, executor }, interaction, { user, reason, dmd }) {
+    async execute({ logger, executor }, interaction, { user, reason, dmt }) {
         const guild = await interaction.client.guilds.fetch(interaction.guildId)
         const member = await guild.members.fetch(user).catch(() => {})
         const moderator = await guild.members.fetch(executor.user)
@@ -40,7 +41,7 @@ export default new ModerationCommand({
                 )
         }
 
-        const dms = Math.floor(dmd ? parseDuration(dmd) : 0 / 1000)
+        const dms = Math.floor((dmt ? parseDuration(dmt, 'd') : 0) / 1000)
         await interaction.guild!.members.ban(user, {
             reason: `Banned by moderator ${executor.user.tag} (${executor.id}): ${reason}`,
             deleteMessageSeconds: dms,

bots/discord/src/commands/moderation/mute.ts

@@ -14,13 +14,13 @@ export default new ModerationCommand({
             required: true,
             type: ModerationCommand.OptionType.User,
         },
-        reason: {
-            description: 'The reason for muting the member',
+        duration: {
+            description: 'The duration of the mute (default time unit is minutes)',
             required: false,
             type: ModerationCommand.OptionType.String,
         },
-        duration: {
-            description: 'The duration of the mute',
+        reason: {
+            description: 'The reason for muting the member',
             required: false,
             type: ModerationCommand.OptionType.String,
         },
@@ -33,7 +33,7 @@ export default new ModerationCommand({
         const guild = await interaction.client.guilds.fetch(interaction.guildId)
         const member = await guild.members.fetch(user.id)
         const moderator = await guild.members.fetch(executor.id)
-        const duration = durationInput ? parseDuration(durationInput) : Infinity
+        const duration = durationInput ? parseDuration(durationInput, 'm') : Infinity
 
         if (Number.isInteger(duration) && duration! < 1)
             throw new CommandError(

bots/discord/src/commands/moderation/role-preset.ts

@@ -11,12 +11,12 @@ const SubcommandOptions = {
         type: ModerationCommand.OptionType.User,
     },
     preset: {
-        description: 'The preset to apply or remove',
+        description: 'The preset to manage',
         required: true,
         type: ModerationCommand.OptionType.String,
     },
     duration: {
-        description: 'The duration to apply the preset for (only for apply action)',
+        description: 'The duration to apply the preset for (only for apply action, default time unit is minutes)',
         required: false,
         type: ModerationCommand.OptionType.String,
     },
@@ -53,7 +53,7 @@ export default new ModerationCommand({
             throw new CommandError(CommandErrorType.Generic, 'This user cannot be managed by the bot.')
 
         if (apply) {
-            const duration = durationInput ? parseDuration(durationInput) : Infinity
+            const duration = durationInput ? parseDuration(durationInput, 'm') : Infinity
             if (Number.isInteger(duration) && duration! < 1)
                 throw new CommandError(
                     CommandErrorType.InvalidArgument,
@@ -83,6 +83,13 @@ export default new ModerationCommand({
                 removeRolePreset(member, preset)
             }, expires)
 
-        await sendPresetReplyAndLogs(apply ? 'apply' : 'remove', trigger, executor, user, preset, expires ? Math.ceil(expires / 1000) : undefined)
+        await sendPresetReplyAndLogs(
+            apply ? 'apply' : 'remove',
+            trigger,
+            executor,
+            user,
+            preset,
+            expires ? Math.ceil(expires / 1000) : undefined,
+        )
     },
 })

bots/discord/src/commands/moderation/slowmode.ts

@@ -10,7 +10,7 @@ export default new ModerationCommand({
     description: 'Set a slowmode for a channel',
     options: {
         duration: {
-            description: 'The duration to set',
+            description: 'The duration to set (default time unit is seconds)',
             required: true,
             type: ModerationCommand.OptionType.String,
         },
@@ -23,13 +23,10 @@ export default new ModerationCommand({
     },
     async execute({ logger, executor }, interaction, { duration: durationInput, channel: channelInput }) {
         const channel = channelInput ?? (await interaction.guild!.channels.fetch(interaction.channelId))
-        const duration = parseDuration(durationInput)
+        const duration = parseDuration(durationInput, 's')
 
         if (!channel?.isTextBased() || channel.isDMBased())
-            throw new CommandError(
-                CommandErrorType.InvalidArgument,
-                'The supplied channel is not a text channel.',
-            )
+            throw new CommandError(CommandErrorType.InvalidArgument, 'The supplied channel is not a text channel.')
 
         if (Number.isNaN(duration)) throw new CommandError(CommandErrorType.InvalidArgument, 'Invalid duration.')
         if (duration < 0 || duration > 36e4)

bots/discord/src/context.ts

@@ -1,23 +1,49 @@
 import { Database } from 'bun:sqlite'
 import { existsSync, readFileSync, readdirSync } from 'fs'
-import { join } from 'path'
+import { dirname, join } from 'path'
 import { Client as APIClient } from '@revanced/bot-api'
 import { createLogger } from '@revanced/bot-shared'
 import { Client as DiscordClient, type Message, Partials } from 'discord.js'
 import { drizzle } from 'drizzle-orm/bun-sqlite'
+import type { default as Command, CommandOptionsOptions, CommandType } from './classes/Command'
+import * as schemas from './database/schemas'
 
 // Export some things first, as commands require them
-import config from '../config.js'
-export { config }
+import _firstConfig from '../config.js'
+
+let currentConfig = _firstConfig
+
+// Other parts of the code will access properties of this proxy, they don't care what the target looks like
+export const config = new Proxy(
+    {
+        INSPECTION_WARNING: 'Run `context.__getConfig()` to inspect the latest config.',
+    } as unknown as typeof currentConfig,
+    {
+        get(_, p, receiver) {
+            if (p === 'invalidate')
+                return async () => {
+                    const path = join(dirname(Bun.main), '..', 'config.js')
+                    Loader.registry.delete(path)
+                    currentConfig = (await import(path)).default
+                    logger.debug('New config set')
+                }
+
+            return Reflect.get(currentConfig, p, receiver)
+        },
+        set(_, p, newValue, receiver) {
+            return Reflect.set(currentConfig, p, newValue, receiver)
+        },
+    },
+) as typeof _firstConfig & { invalidate(): void }
+
+export const __getConfig = () => currentConfig
 
 export const logger = createLogger({
     level: config.logLevel === 'none' ? Number.MAX_SAFE_INTEGER : config.logLevel,
 })
 
-import * as commands from './commands'
-import * as schemas from './database/schemas'
-
-import type { default as Command, CommandOptionsOptions, CommandType } from './classes/Command'
+// Importing later because config needs to be exported before
+const commands = await import('./commands')
 
 export const api = {
     client: new APIClient({

bots/discord/src/database/schemas.ts

@@ -16,6 +16,7 @@ export const appliedPresets = sqliteTable(
     {
         memberId: text('member').notNull(),
         guildId: text('guild').notNull(),
+        removedRoles: text('roles', { mode: 'json' }).notNull().$type<string[]>().default([]),
         preset: text('preset').notNull(),
         until: integer('until'),
     },

bots/discord/src/events/discord/cure.ts

@@ -1,9 +1,9 @@
 import { on } from '$/utils/discord/events'
 import { cureNickname } from '$/utils/discord/moderation'
 
-on('guildMemberUpdate', async (oldMember, newMember) => {
+on('guildMemberUpdate', (_, newMember) => {
     if (newMember.user.bot) return
-    if (oldMember.displayName !== newMember.displayName) await cureNickname(newMember)
+    cureNickname(newMember)
 })
 
 on('guildMemberAdd', member => {
@@ -11,7 +11,7 @@ on('guildMemberAdd', member => {
     cureNickname(member)
 })
 
-on('messageCreate', async msg => {
+on('messageCreate', msg => {
     if (msg.author.bot || !msg.member) return
-    await cureNickname(msg.member)
+    cureNickname(msg.member)
 })

bots/discord/src/events/discord/guildMemberAdd/applyRolePresets.ts

@@ -12,5 +12,5 @@ withContext(on, 'guildMemberAdd', async ({ database }, member) => {
         ),
     })
 
-    for (const { preset } of applieds) await applyRolesUsingPreset(preset, member, true)
+    for (const { preset } of applieds) await applyRolesUsingPreset(preset, member)
 })

bots/discord/src/events/discord/messageCreate/messageScan.ts

@@ -1,4 +1,3 @@
-import { MessageScanLabeledResponseReactions } from '$/constants'
 import { responses } from '$/database/schemas'
 import { getResponseFromText, messageMatchesFilter } from '$/utils/discord/messageScan'
 import { createMessageScanResponseEmbed } from '$utils/discord/embeds'
@@ -22,7 +21,7 @@ withContext(on, 'messageCreate', async (context, msg) => {
 
     if (msg.content.length) {
         try {
-            logger.debug(`Classifying message ${msg.id}`)
+            logger.debug(`Classifying message ${msg.id}, possible responses is ${filteredResponses.length}`)
 
             const { response, label, respondToReply } = await getResponseFromText(
                 msg.content,
@@ -48,10 +47,6 @@ withContext(on, 'messageCreate', async (context, msg) => {
                         label,
                         content: msg.content,
                     })
-
-                    for (const reaction of Object.values(MessageScanLabeledResponseReactions)) {
-                        await reply.react(reaction)
-                    }
                 }
             }
         } catch (e) {
@@ -60,16 +55,13 @@ withContext(on, 'messageCreate', async (context, msg) => {
     }
 
     if (msg.attachments.size && config.attachments?.scanAttachments) {
-        logger.debug(`Classifying message attachments for ${msg.id}`)
+        logger.debug(`Classifying message attachments for ${msg.id}, possible responses is ${filteredResponses.length}`)
 
         for (const attachment of msg.attachments.values()) {
             const mimeType = attachment.contentType?.split(';')?.[0]
             if (!mimeType) return void logger.warn(`No MIME type for attachment: ${attachment.url}`)
 
-            if (
-                config.attachments.allowedMimeTypes &&
-                !config.attachments.allowedMimeTypes.includes(mimeType)
-            ) {
+            if (config.attachments.allowedMimeTypes && !config.attachments.allowedMimeTypes.includes(mimeType)) {
                 logger.debug(`Disallowed MIME type for attachment: ${attachment.url}, ${mimeType}`)
                 continue
             }
@@ -86,10 +78,14 @@ withContext(on, 'messageCreate', async (context, msg) => {
 
                 if (isTextFile) {
                     const content = await (await fetch(attachment.url)).text()
-                    response = await getResponseFromText(content, filteredResponses, context, { skipApiRequest: true }).then(it => it.response)
+                    response = await getResponseFromText(content, filteredResponses, context, {
+                        textRegexesOnly: true,
+                    }).then(it => it.response)
                 } else {
                     const { text: content } = await api.client.parseImage(attachment.url)
-                    response = await getResponseFromText(content, filteredResponses, context, { onlyImageTriggers: true }).then(it => it.response)
+                    response = await getResponseFromText(content, filteredResponses, context, {
+                        imageTriggersOnly: true,
+                    }).then(it => it.response)
                 }
 
                 if (response) {

bots/discord/src/events/discord/messageCreate/stickyMessageReset.ts

@@ -7,22 +7,18 @@ withContext(on, 'messageCreate', async ({ discord, logger }, msg) => {
     const store = discord.stickyMessages[msg.guildId]?.[msg.channelId]
     if (!store) return
 
-    // If there isn't a timer, start it up
-    store.timerActive = true
-    if (!store.timer) store.timer = setTimeout(store.send, store.timerMs) as NodeJS.Timeout
-    else {
-        // If there is a timer, but it isn't active, restart it
-        if (!store.timerActive) store.timer.refresh()
-        // If there is a timer and it is active, but the force timer isn't active...
-        else if (!store.forceTimerActive && store.forceTimerMs) {
-            logger.debug(`Channel ${msg.channelId} in guild ${msg.guildId} is active, starting force send timer and clearing existing timer`)
+    if (store.timerActive) {
+        if (!store.forceTimerActive && store.forceTimerMs) {
+            logger.debug(
+                `Channel ${msg.channelId} in guild ${msg.guildId} is active, starting force send timer and clearing existing timer`,
+            )
 
             // Clear the timer
             clearTimeout(store.timer)
             store.timerActive = false
-            store.forceTimerActive = true
 
             // (Re)start the force timer
+            store.forceTimerActive = true
             if (!store.forceTimer)
                 store.forceTimer = setTimeout(
                     () =>
@@ -33,5 +29,8 @@ withContext(on, 'messageCreate', async ({ discord, logger }, msg) => {
                 ) as NodeJS.Timeout
             else store.forceTimer.refresh()
         }
+    } else if (!store.forceTimerActive) {
+        store.timerActive = true
+        if (!store.timer) store.timer = setTimeout(store.send, store.timerMs) as NodeJS.Timeout
     }
 })

bots/discord/src/events/discord/ready.ts

@@ -60,7 +60,7 @@ export default withContext(on, 'ready', async ({ config, discord, logger }, clie
                         )
                     }
                 }
-                
+
                 // Set up the store
                 discord.stickyMessages[guildId]![channelId] = {
                     forceTimerActive: false,
@@ -69,7 +69,7 @@ export default withContext(on, 'ready', async ({ config, discord, logger }, clie
                     timerMs: timeout,
                     send,
                     // If the store exists before the configuration refresh, take its current message
-                    currentMessage: oldStore?.[channelId]?.currentMessage
+                    currentMessage: oldStore?.[channelId]?.currentMessage,
                 }
 
                 // Send a new sticky message immediately, as well as deleting the old/outdated message, if it exists

bots/discord/src/utils/discord/messageScan.ts

@@ -1,6 +1,7 @@
 import { type Response, responses } from '$/database/schemas'
 import type { Config, ConfigMessageScanResponse, ConfigMessageScanResponseLabelConfig } from 'config.schema'
-import type { Message, PartialUser, User } from 'discord.js'
+import { ButtonStyle, ComponentType } from 'discord.js'
+import type { APIActionRowComponent, APIButtonComponent, Message, PartialUser, User } from 'discord.js'
 import { eq } from 'drizzle-orm'
 import { createMessageScanResponseEmbed } from './embeds'
 
@@ -9,7 +10,7 @@ export const getResponseFromText = async (
     responses: ConfigMessageScanResponse[],
     // Just to be safe that we will never use data from the context parameter
     { api, logger }: Omit<typeof import('src/context'), 'config'>,
-    flags: { onlyImageTriggers?: boolean; skipApiRequest?: boolean } = {}
+    flags: { imageTriggersOnly?: boolean; textRegexesOnly?: boolean } = {},
 ): Promise<
     Omit<ConfigMessageScanResponse, 'triggers'> & { label?: string; triggers?: ConfigMessageScanResponse['triggers'] }
 > => {
@@ -31,7 +32,7 @@ export const getResponseFromText = async (
             triggers: { text: textTriggers, image: imageTriggers },
         } = trigger
 
-        if (flags.onlyImageTriggers) {
+        if (flags.imageTriggersOnly) {
             if (imageTriggers)
                 for (const regex of imageTriggers)
                     if (regex.test(content)) {
@@ -39,7 +40,7 @@ export const getResponseFromText = async (
                         responseConfig = trigger
                         break
                     }
-        } else
+        } else {
             for (let j = 0; j < textTriggers!.length; j++) {
                 const regex = textTriggers![j]!
 
@@ -54,10 +55,11 @@ export const getResponseFromText = async (
                     break
                 }
             }
+        }
     }
 
     // If none of the regexes match, we can search for labels immediately
-    if (!responseConfig.triggers && !flags.onlyImageTriggers && !flags.skipApiRequest) {
+    if (!responseConfig.triggers && !flags.textRegexesOnly) {
         logger.debug('No match from before regexes, doing NLP')
         const scan = await api.client.parseText(content)
         if (scan.labels.length) {
@@ -87,7 +89,7 @@ export const getResponseFromText = async (
     }
 
     // If we still don't have a response config, we can match all regexes after the initial label trigger
-    if (!responseConfig.triggers && flags.onlyImageTriggers) {
+    if (!responseConfig.triggers && !flags.imageTriggersOnly) {
         logger.debug('No match from NLP, doing after regexes')
         for (let i = 0; i < responses.length; i++) {
             const {
@@ -159,14 +161,41 @@ export const handleUserResponseCorrection = async (
             })
             .where(eq(responses.replyId, response.replyId))
 
-        await reply.edit({
+        return void (await reply.edit({
             ...correctLabelResponse.response,
             embeds: correctLabelResponse.response.embeds?.map(createMessageScanResponseEmbed),
-        })
+            components: [],
+        }))
     }
 
     await api.client.trainMessage(response.content, label)
     logger.debug(`User ${user.id} trained message ${response.replyId} as ${label} (positive)`)
 
-    await reply.reactions.removeAll()
+    await reply.edit({
+        components: [],
+    })
 }
+
+export const createMessageScanResponseComponents = (reply: Message<true>) => [
+    {
+        type: ComponentType.ActionRow,
+        components: [
+            {
+                type: ComponentType.Button,
+                style: ButtonStyle.Secondary,
+                emoji: {
+                    id: '👍',
+                },
+                custom_id: `train:${reply.id}`,
+            },
+            {
+                type: ComponentType.Button,
+                style: ButtonStyle.Secondary,
+                emoji: {
+                    id: '🔧',
+                },
+                custom_id: `edit:${reply.id}`,
+            },
+        ],
+    } as APIActionRowComponent<APIButtonComponent>,
+]

bots/discord/src/utils/discord/moderation.ts

@@ -23,10 +23,7 @@ export const sendPresetReplyAndLogs = (
         ]),
     )
 
-export const sendModerationReplyAndLogs = async (
-    interaction: CommandInteraction | Message,
-    embed: EmbedBuilder,
-) => {
+export const sendModerationReplyAndLogs = async (interaction: CommandInteraction | Message, embed: EmbedBuilder) => {
     const reply = await interaction.reply({ embeds: [embed] }).then(it => it.fetch())
     const logChannel = await getLogChannel(interaction.guild!)
     await logChannel?.send({ embeds: [applyReferenceToModerationActionEmbed(embed, reply.url)] })

bots/discord/src/utils/discord/rolePresets.ts

@@ -7,7 +7,7 @@ import { and, eq } from 'drizzle-orm'
 type PresetKey = string
 
 export const applyRolePreset = async (member: GuildMember, presetName: PresetKey, expires: number) => {
-    const afterInsert = await applyRolesUsingPreset(presetName, member, true)
+    const { removed, callback } = await applyRolesUsingPreset(presetName, member)
     const until = expires === Infinity ? null : Math.ceil(expires / 1000)
 
     await database
@@ -16,39 +16,60 @@ export const applyRolePreset = async (member: GuildMember, presetName: PresetKey
             memberId: member.id,
             guildId: member.guild.id,
             preset: presetName,
+            removedRoles: removed,
             until,
         })
         .onConflictDoUpdate({
             target: [appliedPresets.memberId, appliedPresets.preset, appliedPresets.guildId],
             set: { until },
         })
-        .then(afterInsert)
+        .then(callback)
 }
 
 export const removeRolePreset = async (member: GuildMember, presetName: PresetKey) => {
-    const afterDelete = await applyRolesUsingPreset(presetName, member, false)
+    const where = and(
+        eq(appliedPresets.memberId, member.id),
+        eq(appliedPresets.preset, presetName),
+        eq(appliedPresets.guildId, member.guild.id),
+    )
 
-    await database
-        .delete(appliedPresets)
-        .where(
-            and(
-                eq(appliedPresets.memberId, member.id),
-                eq(appliedPresets.preset, presetName),
-                eq(appliedPresets.guildId, member.guild.id),
-            ),
-        )
-        .execute()
-        .then(afterDelete)
+    const data = await database.query.appliedPresets.findFirst({ where })
+    if (!data) return false
+
+    const { callback } = await applyRolesUsingPreset(presetName, member, data.removedRoles)
+    await database.delete(appliedPresets).where(where).execute().then(callback)
+
+    return true
 }
 
-export const applyRolesUsingPreset = async (presetName: string, member: GuildMember, applying: boolean) => {
+export const applyRolesUsingPreset = async (
+    presetName: string,
+    member: GuildMember,
+    removePresetGiveRoles?: string[],
+) => {
     const preset = config.rolePresets?.guilds[member.guild.id]?.[presetName]
     if (!preset) throw new Error(`The preset "${presetName}" does not exist for this server`)
 
     const roles = new Set(member.roles.cache.keys())
+    const removed: string[] = []
 
-    for (const role of preset.give) roles[applying ? 'add' : 'delete'](role)
-    for (const role of preset.take) roles[applying ? 'delete' : 'add'](role)
+    // If removePresetGiveRoles is not provided, we're applying a preset
+    if (!removePresetGiveRoles) {
+        for (const role of preset.give) roles.add(role)
+        for (const role of preset.take) {
+            if (roles.has(role)) {
+                roles.delete(role)
+                removed.push(role)
+            }
+        }
+    } else {
+        const guildRoles = await member.guild.roles.fetch()
+        for (const role of preset.give) roles.delete(role)
+        for (const role of removePresetGiveRoles) if (guildRoles.has(role)) roles.add(role)
+    }
 
-    return () => member.roles.set(Array.from(roles))
+    return {
+        removed,
+        callback: () => member.roles.set(Array.from(roles)),
+    }
 }

bots/discord/src/utils/duration.ts

@@ -1,16 +1,13 @@
-export const parseDuration = (duration: string) => {
-    if (!duration.length) return Number.NaN
-    const matches = duration.match(/(?:(\d+y)?(\d+M)?(\d+w)?(\d+)d)?(?:(\d+)h)?(?:(\d+)m)?(?:(\d+)s?)/)!
+import parse from 'parse-duration'
 
-    const [, years, months, weeks, days, hours, minutes, seconds] = matches.map(Number)
+const defaultUnitValue = parse['']!
+
+export const parseDuration = (duration: string, defaultUnit?: parse.Units) => {
+    if (defaultUnit) parse[''] = parse[defaultUnit]!
     return (
-        (years || 0) * 290304e5 +
-        (months || 0) * 24192e5 +
-        (weeks || 0) * 6048e5 +
-        (days || 0) * 864e5 +
-        (hours || 0) * 36e5 +
-        (minutes || 0) * 6e4 +
-        (seconds || 0) * 1e3
+        // biome-ignore lint/suspicious/noAssignInExpressions: Expression is ignored
+        // biome-ignore lint/style/noCommaOperator: The last expression (parse call) is returned, it is not confusing
+        (parse[''] = defaultUnitValue), parse(duration, 'ms') ?? Number.NaN
     )
 }
 

package.json

@@ -30,22 +30,22 @@
   "packageManager": "bun@1.1.20",
   "devDependencies": {
     "@anolilab/multi-semantic-release": "^1.1.3",
-    "@biomejs/biome": "^1.8.3",
+    "@biomejs/biome": "^1.9.2",
     "@codedependant/semantic-release-docker": "^5.0.3",
-    "@commitlint/cli": "^19.3.0",
-    "@commitlint/config-conventional": "^19.2.2",
+    "@commitlint/cli": "^19.5.0",
+    "@commitlint/config-conventional": "^19.5.0",
     "@saithodev/semantic-release-backmerge": "^4.0.1",
     "@semantic-release/changelog": "^6.0.3",
     "@semantic-release/exec": "^6.0.3",
     "@semantic-release/git": "^10.0.1",
     "@tsconfig/strictest": "^2.0.5",
-    "@types/bun": "^1.1.6",
+    "@types/bun": "^1.1.10",
     "conventional-changelog-conventionalcommits": "^7.0.2",
-    "lefthook": "^1.7.5",
+    "lefthook": "^1.7.15",
     "portainer-service-webhook": "https://github.com/newarifrh/portainer-service-webhook#v1",
-    "semantic-release": "^24.0.0",
-    "turbo": "^2.0.9",
-    "typescript": "^5.5.4"
+    "semantic-release": "^24.1.1",
+    "turbo": "^2.1.2",
+    "typescript": "^5.6.2"
   },
   "trustedDependencies": [
     "@biomejs/biome",

packages/api/package.json

@@ -28,10 +28,10 @@
   "homepage": "https://github.com/revanced/revanced-helper#readme",
   "dependencies": {
     "@revanced/bot-shared": "workspace:*",
-    "ws": "^8.17.1"
+    "ws": "^8.18.0"
   },
   "devDependencies": {
-    "@types/ws": "^8.5.10",
+    "@types/ws": "^8.5.12",
     "typed-emitter": "^2.1.0"
   }
 }

packages/api/src/classes/ClientWebSocket.ts

@@ -35,7 +35,7 @@ export class ClientWebSocketManager {
 
     /**
      * Sets the URL to connect to
-     * 
+     *
      * **Requires a reconnect to take effect**
      */
     async setOptions({ url, timeout }: Partial<ClientWebSocketManagerOptions>, autoReconnect = true) {

packages/shared/package.json

@@ -30,7 +30,7 @@
   },
   "homepage": "https://github.com/revanced/revanced-helper#readme",
   "dependencies": {
-    "bson": "^6.7.0",
+    "bson": "^6.8.0",
     "chalk": "^5.3.0",
     "tracer": "^1.3.0",
     "valibot": "^0.30.0"

packages/shared/src/schemas/Packet.ts

@@ -1,18 +1,18 @@
 import {
+    url,
     type AnySchema,
+    type BooleanSchema,
     type NullSchema,
     type ObjectSchema,
     type Output,
-    type BooleanSchema,
     array,
+    boolean,
     enum_,
     null_,
     object,
     parse,
     special,
     string,
-    boolean,
-    url,
     // merge
 } from 'valibot'
 import DisconnectReason from '../constants/DisconnectReason'