mirror of
https://github.com/ReVanced/revanced-patches.git
synced 2026-01-25 11:41:04 +00:00
remove deprecated migration code
This commit is contained in:
@@ -11,6 +11,7 @@ import android.widget.Toolbar;
|
||||
import app.revanced.extension.music.settings.preference.MusicPreferenceFragment;
|
||||
import app.revanced.extension.music.settings.search.MusicSearchViewController;
|
||||
import app.revanced.extension.shared.Logger;
|
||||
import app.revanced.extension.shared.ResourceType;
|
||||
import app.revanced.extension.shared.Utils;
|
||||
import app.revanced.extension.shared.settings.BaseActivityHook;
|
||||
|
||||
@@ -46,7 +47,7 @@ public class MusicActivityHook extends BaseActivityHook {
|
||||
// Override the default YouTube Music theme to increase start padding of list items.
|
||||
// Custom style located in resources/music/values/style.xml
|
||||
activity.setTheme(Utils.getResourceIdentifierOrThrow(
|
||||
"Theme.ReVanced.YouTubeMusic.Settings", "style"));
|
||||
ResourceType.STYLE, "Theme.ReVanced.YouTubeMusic.Settings"));
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
@@ -328,53 +328,6 @@ public class Utils {
|
||||
return getResourceIdentifierOrThrow(getContext(), type, resourceIdentifierName);
|
||||
}
|
||||
|
||||
/**
|
||||
* @return The resource identifier, or throws an exception if not found.
|
||||
*/
|
||||
@Deprecated
|
||||
public static int getResourceIdentifierOrThrow(Context context, String resourceIdentifierName, @Nullable String type) {
|
||||
final int resourceId = getResourceIdentifier(context, type, resourceIdentifierName);
|
||||
if (resourceId == 0) {
|
||||
throw new Resources.NotFoundException("No resource id exists with name: " + resourceIdentifierName
|
||||
+ " type: " + type);
|
||||
}
|
||||
return resourceId;
|
||||
}
|
||||
|
||||
|
||||
/**
|
||||
* Instead use {@link #getResourceIdentifierOrThrow(ResourceType, String)}
|
||||
*/
|
||||
@Deprecated
|
||||
public static int getResourceIdentifierOrThrow(String resourceIdentifierName, @Nullable String stringType) {
|
||||
return getResourceIdentifierOrThrow(getContext(), resourceIdentifierName, stringType);
|
||||
}
|
||||
|
||||
/**
|
||||
* Instead use {@link #getResourceIdentifier(ResourceType, String)}
|
||||
*/
|
||||
@Deprecated
|
||||
public static int getResourceIdentifier(String resourceIdentifierName, @Nullable String stringType) {
|
||||
return getResourceIdentifier(getContext(), resourceIdentifierName, stringType);
|
||||
}
|
||||
|
||||
/**
|
||||
* Instead use {@link #getResourceIdentifier(Context, ResourceType, String)}
|
||||
*/
|
||||
@Deprecated
|
||||
public static int getResourceIdentifier(Context context, String resourceIdentifierName, @Nullable String stringType) {
|
||||
// Find ResourceType with same name as type parameter string
|
||||
ResourceType convertedType = null;
|
||||
for (ResourceType type : ResourceType.values()) {
|
||||
if (type.value.equals(stringType)) {
|
||||
convertedType = type;
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
return getResourceIdentifierOrThrow(context, convertedType, resourceIdentifierName);
|
||||
}
|
||||
|
||||
public static int getResourceInteger(String resourceIdentifierName) throws Resources.NotFoundException {
|
||||
return getContext().getResources().getInteger(getResourceIdentifierOrThrow(ResourceType.INTEGER, resourceIdentifierName));
|
||||
}
|
||||
|
||||
@@ -129,7 +129,7 @@ abstract class Check {
|
||||
// Add icon to the dialog.
|
||||
ImageView iconView = new ImageView(activity);
|
||||
iconView.setImageResource(Utils.getResourceIdentifierOrThrow(
|
||||
"revanced_ic_dialog_alert", "drawable"));
|
||||
ResourceType.DRAWABLE, "revanced_ic_dialog_alert"));
|
||||
iconView.setColorFilter(Utils.getAppForegroundColor(), PorterDuff.Mode.SRC_IN);
|
||||
iconView.setPadding(0, 0, 0, 0);
|
||||
LinearLayout.LayoutParams iconParams = new LinearLayout.LayoutParams(
|
||||
|
||||
@@ -26,13 +26,13 @@ import app.revanced.extension.shared.settings.preference.ToolbarPreferenceFragme
|
||||
public abstract class BaseActivityHook extends Activity {
|
||||
|
||||
private static final int ID_REVANCED_SETTINGS_FRAGMENTS =
|
||||
getResourceIdentifierOrThrow("revanced_settings_fragments", "id");
|
||||
getResourceIdentifierOrThrow(ResourceType.ID, "revanced_settings_fragments");
|
||||
private static final int ID_REVANCED_TOOLBAR_PARENT =
|
||||
getResourceIdentifierOrThrow("revanced_toolbar_parent", "id");
|
||||
getResourceIdentifierOrThrow(ResourceType.ID, "revanced_toolbar_parent");
|
||||
public static final int LAYOUT_REVANCED_SETTINGS_WITH_TOOLBAR =
|
||||
getResourceIdentifierOrThrow("revanced_settings_with_toolbar", "layout");
|
||||
getResourceIdentifierOrThrow(ResourceType.LAYOUT, "revanced_settings_with_toolbar");
|
||||
private static final int STRING_REVANCED_SETTINGS_TITLE =
|
||||
getResourceIdentifierOrThrow("revanced_settings_title", "string");
|
||||
getResourceIdentifierOrThrow(ResourceType.STRING, "revanced_settings_title");
|
||||
|
||||
/**
|
||||
* Layout parameters for the toolbar, extracted from the dummy toolbar.
|
||||
|
||||
@@ -20,6 +20,7 @@ import android.widget.TextView;
|
||||
import androidx.annotation.NonNull;
|
||||
import androidx.annotation.Nullable;
|
||||
|
||||
import app.revanced.extension.shared.ResourceType;
|
||||
import app.revanced.extension.shared.Utils;
|
||||
import app.revanced.extension.shared.ui.CustomDialog;
|
||||
|
||||
@@ -30,14 +31,14 @@ import app.revanced.extension.shared.ui.CustomDialog;
|
||||
@SuppressWarnings({"unused", "deprecation"})
|
||||
public class CustomDialogListPreference extends ListPreference {
|
||||
|
||||
public static final int ID_REVANCED_CHECK_ICON =
|
||||
getResourceIdentifierOrThrow("revanced_check_icon", "id");
|
||||
public static final int ID_REVANCED_CHECK_ICON_PLACEHOLDER =
|
||||
getResourceIdentifierOrThrow("revanced_check_icon_placeholder", "id");
|
||||
public static final int ID_REVANCED_ITEM_TEXT =
|
||||
getResourceIdentifierOrThrow("revanced_item_text", "id");
|
||||
public static final int LAYOUT_REVANCED_CUSTOM_LIST_ITEM_CHECKED =
|
||||
getResourceIdentifierOrThrow("revanced_custom_list_item_checked", "layout");
|
||||
public static final int ID_REVANCED_CHECK_ICON = getResourceIdentifierOrThrow(
|
||||
ResourceType.ID, "revanced_check_icon");
|
||||
public static final int ID_REVANCED_CHECK_ICON_PLACEHOLDER = getResourceIdentifierOrThrow(
|
||||
ResourceType.ID, "revanced_check_icon_placeholder");
|
||||
public static final int ID_REVANCED_ITEM_TEXT = getResourceIdentifierOrThrow(
|
||||
ResourceType.ID, "revanced_item_text");
|
||||
public static final int LAYOUT_REVANCED_CUSTOM_LIST_ITEM_CHECKED = getResourceIdentifierOrThrow(
|
||||
ResourceType.LAYOUT, "revanced_custom_list_item_checked");
|
||||
|
||||
private String staticSummary = null;
|
||||
private CharSequence[] highlightedEntriesForDialog = null;
|
||||
|
||||
@@ -16,6 +16,7 @@ import java.util.List;
|
||||
import java.util.regex.Matcher;
|
||||
import java.util.regex.Pattern;
|
||||
|
||||
import app.revanced.extension.shared.ResourceType;
|
||||
import app.revanced.extension.shared.Utils;
|
||||
import app.revanced.extension.shared.settings.preference.ColorPickerPreference;
|
||||
import app.revanced.extension.shared.settings.preference.CustomDialogListPreference;
|
||||
@@ -38,18 +39,18 @@ public abstract class BaseSearchResultItem {
|
||||
// Get the corresponding layout resource ID.
|
||||
public int getLayoutResourceId() {
|
||||
return switch (this) {
|
||||
case REGULAR, URL_LINK -> getResourceIdentifier("revanced_preference_search_result_regular");
|
||||
case SWITCH -> getResourceIdentifier("revanced_preference_search_result_switch");
|
||||
case LIST -> getResourceIdentifier("revanced_preference_search_result_list");
|
||||
case COLOR_PICKER -> getResourceIdentifier("revanced_preference_search_result_color");
|
||||
case GROUP_HEADER -> getResourceIdentifier("revanced_preference_search_result_group_header");
|
||||
case NO_RESULTS -> getResourceIdentifier("revanced_preference_search_no_result");
|
||||
case REGULAR, URL_LINK -> getResourceIdentifier("revanced_preference_search_result_regular");
|
||||
case SWITCH -> getResourceIdentifier("revanced_preference_search_result_switch");
|
||||
case LIST -> getResourceIdentifier("revanced_preference_search_result_list");
|
||||
case COLOR_PICKER -> getResourceIdentifier("revanced_preference_search_result_color");
|
||||
case GROUP_HEADER -> getResourceIdentifier("revanced_preference_search_result_group_header");
|
||||
case NO_RESULTS -> getResourceIdentifier("revanced_preference_search_no_result");
|
||||
};
|
||||
}
|
||||
|
||||
private static int getResourceIdentifier(String name) {
|
||||
// Placeholder for actual resource identifier retrieval.
|
||||
return Utils.getResourceIdentifierOrThrow(name, "layout");
|
||||
return Utils.getResourceIdentifierOrThrow(ResourceType.LAYOUT, name);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -33,6 +33,7 @@ import java.lang.reflect.Method;
|
||||
import java.util.List;
|
||||
|
||||
import app.revanced.extension.shared.Logger;
|
||||
import app.revanced.extension.shared.ResourceType;
|
||||
import app.revanced.extension.shared.Utils;
|
||||
import app.revanced.extension.shared.settings.preference.ColorPickerPreference;
|
||||
import app.revanced.extension.shared.settings.preference.CustomDialogListPreference;
|
||||
@@ -54,15 +55,15 @@ public abstract class BaseSearchResultsAdapter extends ArrayAdapter<BaseSearchRe
|
||||
protected static final int PAUSE_BETWEEN_BLINKS = 100;
|
||||
|
||||
protected static final int ID_PREFERENCE_TITLE = getResourceIdentifierOrThrow(
|
||||
"preference_title", "id");
|
||||
ResourceType.ID, "preference_title");
|
||||
protected static final int ID_PREFERENCE_SUMMARY = getResourceIdentifierOrThrow(
|
||||
"preference_summary", "id");
|
||||
ResourceType.ID, "preference_summary");
|
||||
protected static final int ID_PREFERENCE_PATH = getResourceIdentifierOrThrow(
|
||||
"preference_path", "id");
|
||||
ResourceType.ID, "preference_path");
|
||||
protected static final int ID_PREFERENCE_SWITCH = getResourceIdentifierOrThrow(
|
||||
"preference_switch", "id");
|
||||
ResourceType.ID, "preference_switch");
|
||||
protected static final int ID_PREFERENCE_COLOR_DOT = getResourceIdentifierOrThrow(
|
||||
"preference_color_dot", "id");
|
||||
ResourceType.ID, "preference_color_dot");
|
||||
|
||||
protected static class RegularViewHolder {
|
||||
TextView titleView;
|
||||
|
||||
@@ -34,6 +34,7 @@ import java.util.Set;
|
||||
import java.util.regex.Pattern;
|
||||
|
||||
import app.revanced.extension.shared.Logger;
|
||||
import app.revanced.extension.shared.ResourceType;
|
||||
import app.revanced.extension.shared.Utils;
|
||||
import app.revanced.extension.shared.settings.AppLanguage;
|
||||
import app.revanced.extension.shared.settings.BaseSettings;
|
||||
@@ -66,14 +67,18 @@ public abstract class BaseSearchViewController {
|
||||
|
||||
protected static final int MAX_SEARCH_RESULTS = 50; // Maximum number of search results displayed.
|
||||
|
||||
protected static final int ID_REVANCED_SEARCH_VIEW = getResourceIdentifierOrThrow("revanced_search_view", "id");
|
||||
protected static final int ID_REVANCED_SEARCH_VIEW_CONTAINER = getResourceIdentifierOrThrow("revanced_search_view_container", "id");
|
||||
protected static final int ID_ACTION_SEARCH = getResourceIdentifierOrThrow("action_search", "id");
|
||||
protected static final int ID_REVANCED_SETTINGS_FRAGMENTS = getResourceIdentifierOrThrow("revanced_settings_fragments", "id");
|
||||
public static final int DRAWABLE_REVANCED_SETTINGS_SEARCH_ICON =
|
||||
getResourceIdentifierOrThrow("revanced_settings_search_icon", "drawable");
|
||||
protected static final int MENU_REVANCED_SEARCH_MENU =
|
||||
getResourceIdentifierOrThrow("revanced_search_menu", "menu");
|
||||
protected static final int ID_REVANCED_SEARCH_VIEW = getResourceIdentifierOrThrow(
|
||||
ResourceType.ID, "revanced_search_view");
|
||||
protected static final int ID_REVANCED_SEARCH_VIEW_CONTAINER = getResourceIdentifierOrThrow(
|
||||
ResourceType.ID, "revanced_search_view_container");
|
||||
protected static final int ID_ACTION_SEARCH = getResourceIdentifierOrThrow(
|
||||
ResourceType.ID, "action_search");
|
||||
protected static final int ID_REVANCED_SETTINGS_FRAGMENTS = getResourceIdentifierOrThrow(
|
||||
ResourceType.ID, "revanced_settings_fragments");
|
||||
public static final int DRAWABLE_REVANCED_SETTINGS_SEARCH_ICON = getResourceIdentifierOrThrow(
|
||||
ResourceType.DRAWABLE, "revanced_settings_search_icon");
|
||||
protected static final int MENU_REVANCED_SEARCH_MENU = getResourceIdentifierOrThrow(
|
||||
ResourceType.MENU, "revanced_search_menu");
|
||||
|
||||
/**
|
||||
* Constructs a new BaseSearchViewController instance.
|
||||
@@ -108,7 +113,7 @@ public abstract class BaseSearchViewController {
|
||||
// Retrieve SearchView and container from XML.
|
||||
searchView = activity.findViewById(ID_REVANCED_SEARCH_VIEW);
|
||||
EditText searchEditText = searchView.findViewById(Utils.getResourceIdentifierOrThrow(
|
||||
"android:id/search_src_text", null));
|
||||
null, "android:id/search_src_text"));
|
||||
// Disable fullscreen keyboard mode.
|
||||
searchEditText.setImeOptions(searchEditText.getImeOptions() | EditorInfo.IME_FLAG_NO_EXTRACT_UI);
|
||||
|
||||
|
||||
@@ -24,6 +24,7 @@ import java.util.Deque;
|
||||
import java.util.LinkedList;
|
||||
|
||||
import app.revanced.extension.shared.Logger;
|
||||
import app.revanced.extension.shared.ResourceType;
|
||||
import app.revanced.extension.shared.settings.preference.BulletPointPreference;
|
||||
import app.revanced.extension.shared.ui.CustomDialog;
|
||||
|
||||
@@ -37,25 +38,25 @@ public class SearchHistoryManager {
|
||||
private static final int MAX_HISTORY_SIZE = 5; // Maximum history items stored.
|
||||
|
||||
private static final int ID_CLEAR_HISTORY_BUTTON = getResourceIdentifierOrThrow(
|
||||
"clear_history_button", "id");
|
||||
ResourceType.ID, "clear_history_button");
|
||||
private static final int ID_HISTORY_TEXT = getResourceIdentifierOrThrow(
|
||||
"history_text", "id");
|
||||
ResourceType.ID, "history_text");
|
||||
private static final int ID_DELETE_ICON = getResourceIdentifierOrThrow(
|
||||
"delete_icon", "id");
|
||||
ResourceType.ID, "delete_icon");
|
||||
private static final int ID_EMPTY_HISTORY_TITLE = getResourceIdentifierOrThrow(
|
||||
"empty_history_title", "id");
|
||||
ResourceType.ID, "empty_history_title");
|
||||
private static final int ID_EMPTY_HISTORY_SUMMARY = getResourceIdentifierOrThrow(
|
||||
"empty_history_summary", "id");
|
||||
ResourceType.ID, "empty_history_summary");
|
||||
private static final int ID_SEARCH_HISTORY_HEADER = getResourceIdentifierOrThrow(
|
||||
"search_history_header", "id");
|
||||
ResourceType.ID, "search_history_header");
|
||||
private static final int ID_SEARCH_TIPS_SUMMARY = getResourceIdentifierOrThrow(
|
||||
"revanced_settings_search_tips_summary", "id");
|
||||
ResourceType.ID, "revanced_settings_search_tips_summary");
|
||||
private static final int LAYOUT_REVANCED_PREFERENCE_SEARCH_HISTORY_SCREEN = getResourceIdentifierOrThrow(
|
||||
"revanced_preference_search_history_screen", "layout");
|
||||
ResourceType.LAYOUT, "revanced_preference_search_history_screen");
|
||||
private static final int LAYOUT_REVANCED_PREFERENCE_SEARCH_HISTORY_ITEM = getResourceIdentifierOrThrow(
|
||||
"revanced_preference_search_history_item", "layout");
|
||||
ResourceType.LAYOUT, "revanced_preference_search_history_item");
|
||||
private static final int ID_SEARCH_HISTORY_LIST = getResourceIdentifierOrThrow(
|
||||
"search_history_list", "id");
|
||||
ResourceType.ID, "search_history_list");
|
||||
|
||||
private final Deque<String> searchHistory;
|
||||
private final Activity activity;
|
||||
|
||||
@@ -7,6 +7,7 @@ import android.view.ViewGroup;
|
||||
import android.widget.ImageView;
|
||||
|
||||
import app.revanced.extension.shared.Logger;
|
||||
import app.revanced.extension.shared.ResourceType;
|
||||
import app.revanced.extension.shared.Utils;
|
||||
import app.revanced.extension.youtube.settings.Settings;
|
||||
|
||||
@@ -40,10 +41,10 @@ public final class HidePlayerOverlayButtonsPatch {
|
||||
= Settings.HIDE_PLAYER_PREVIOUS_NEXT_BUTTONS.get();
|
||||
|
||||
private static final int PLAYER_CONTROL_PREVIOUS_BUTTON_TOUCH_AREA_ID = getResourceIdentifierOrThrow(
|
||||
"player_control_previous_button_touch_area", "id");
|
||||
ResourceType.ID, "player_control_previous_button_touch_area");
|
||||
|
||||
private static final int PLAYER_CONTROL_NEXT_BUTTON_TOUCH_AREA_ID = getResourceIdentifierOrThrow(
|
||||
"player_control_next_button_touch_area", "id");
|
||||
ResourceType.ID, "player_control_next_button_touch_area");
|
||||
|
||||
/**
|
||||
* Injection point.
|
||||
|
||||
@@ -15,6 +15,7 @@ import android.widget.FrameLayout;
|
||||
import android.widget.ImageButton;
|
||||
|
||||
import app.revanced.extension.shared.Logger;
|
||||
import app.revanced.extension.shared.ResourceType;
|
||||
import app.revanced.extension.youtube.patches.VideoInformation;
|
||||
import app.revanced.extension.youtube.settings.Settings;
|
||||
import app.revanced.extension.youtube.sponsorblock.SponsorBlockUtils;
|
||||
@@ -44,8 +45,8 @@ public final class NewSegmentLayout extends FrameLayout {
|
||||
final int defStyleAttr, final int defStyleRes) {
|
||||
super(context, attributeSet, defStyleAttr, defStyleRes);
|
||||
|
||||
LayoutInflater.from(context).inflate(
|
||||
getResourceIdentifierOrThrow(context, "revanced_sb_new_segment", "layout"), this, true
|
||||
LayoutInflater.from(context).inflate(getResourceIdentifierOrThrow(context,
|
||||
ResourceType.LAYOUT, "revanced_sb_new_segment"), this, true
|
||||
);
|
||||
|
||||
initializeButton(
|
||||
@@ -104,7 +105,7 @@ public final class NewSegmentLayout extends FrameLayout {
|
||||
*/
|
||||
private void initializeButton(final Context context, final String resourceIdentifierName,
|
||||
final ButtonOnClickHandlerFunction handler, final String debugMessage) {
|
||||
ImageButton button = findViewById(getResourceIdentifierOrThrow(context, resourceIdentifierName, "id"));
|
||||
ImageButton button = findViewById(getResourceIdentifierOrThrow(context, ResourceType.ID, resourceIdentifierName));
|
||||
|
||||
// Add ripple effect
|
||||
RippleDrawable rippleDrawable = new RippleDrawable(
|
||||
|
||||
@@ -64,9 +64,10 @@ public class SponsorBlockViewController {
|
||||
|
||||
Context context = Utils.getContext();
|
||||
RelativeLayout layout = new RelativeLayout(context);
|
||||
layout.setLayoutParams(new RelativeLayout.LayoutParams(RelativeLayout.LayoutParams.MATCH_PARENT,RelativeLayout.LayoutParams.MATCH_PARENT));
|
||||
layout.setLayoutParams(new RelativeLayout.LayoutParams(
|
||||
RelativeLayout.LayoutParams.MATCH_PARENT, RelativeLayout.LayoutParams.MATCH_PARENT));
|
||||
LayoutInflater.from(context).inflate(getResourceIdentifierOrThrow(
|
||||
"revanced_sb_inline_sponsor_overlay", "layout"), layout);
|
||||
ResourceType.LAYOUT, "revanced_sb_inline_sponsor_overlay"), layout);
|
||||
inlineSponsorOverlayRef = new WeakReference<>(layout);
|
||||
|
||||
viewGroup.addView(layout);
|
||||
@@ -85,14 +86,14 @@ public class SponsorBlockViewController {
|
||||
});
|
||||
youtubeOverlaysLayoutRef = new WeakReference<>(viewGroup);
|
||||
|
||||
skipHighlightButtonRef = new WeakReference<>(Objects.requireNonNull(
|
||||
layout.findViewById(getResourceIdentifier("revanced_sb_skip_highlight_button", "id"))));
|
||||
skipHighlightButtonRef = new WeakReference<>(Objects.requireNonNull(layout.findViewById(
|
||||
getResourceIdentifier(ResourceType.ID, "revanced_sb_skip_highlight_button"))));
|
||||
|
||||
skipSponsorButtonRef = new WeakReference<>(Objects.requireNonNull(
|
||||
layout.findViewById(getResourceIdentifier("revanced_sb_skip_sponsor_button", "id"))));
|
||||
skipSponsorButtonRef = new WeakReference<>(Objects.requireNonNull(layout.findViewById(
|
||||
getResourceIdentifier(ResourceType.ID, "revanced_sb_skip_sponsor_button"))));
|
||||
|
||||
NewSegmentLayout newSegmentLayout = Objects.requireNonNull(
|
||||
layout.findViewById(getResourceIdentifier("revanced_sb_new_segment_view", "id")));
|
||||
NewSegmentLayout newSegmentLayout = Objects.requireNonNull(layout.findViewById(
|
||||
getResourceIdentifier(ResourceType.ID, "revanced_sb_new_segment_view")));
|
||||
newSegmentLayoutRef = new WeakReference<>(newSegmentLayout);
|
||||
newSegmentLayout.updateLayout();
|
||||
|
||||
|
||||
Reference in New Issue
Block a user