mirror of
https://github.com/hydralauncher/hydra.git
synced 2026-01-11 13:56:16 +00:00
fix: using for...of instead of forEach
This commit is contained in:
@@ -24,11 +24,11 @@ const removeGameFromLibrary = async (
|
||||
game.customHeroImageUrl,
|
||||
];
|
||||
|
||||
assetUrls.forEach((url) => {
|
||||
for (const url of assetUrls) {
|
||||
if (url?.startsWith("local:")) {
|
||||
assetPathsToDelete.push(url.replace("local:", ""));
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
const updatedGame = {
|
||||
...game,
|
||||
|
||||
@@ -19,18 +19,18 @@ const updateCustomGame = async (
|
||||
}
|
||||
|
||||
const oldAssetPaths: string[] = [];
|
||||
|
||||
|
||||
const assetPairs = [
|
||||
{ existing: existingGame.iconUrl, new: iconUrl },
|
||||
{ existing: existingGame.logoImageUrl, new: logoImageUrl },
|
||||
{ existing: existingGame.libraryHeroImageUrl, new: libraryHeroImageUrl }
|
||||
{ existing: existingGame.libraryHeroImageUrl, new: libraryHeroImageUrl },
|
||||
];
|
||||
|
||||
assetPairs.forEach(({ existing, new: newUrl }) => {
|
||||
|
||||
for (const { existing, new: newUrl } of assetPairs) {
|
||||
if (existing?.startsWith("local:") && (!newUrl || existing !== newUrl)) {
|
||||
oldAssetPaths.push(existing.replace("local:", ""));
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
const updatedGame = {
|
||||
...existingGame,
|
||||
|
||||
@@ -26,7 +26,7 @@ const updateGameCustomAssets = async (
|
||||
{ existing: existingGame.customHeroImageUrl, new: customHeroImageUrl },
|
||||
];
|
||||
|
||||
assetPairs.forEach(({ existing, new: newUrl }) => {
|
||||
for (const { existing, new: newUrl } of assetPairs) {
|
||||
if (
|
||||
existing &&
|
||||
newUrl !== undefined &&
|
||||
@@ -35,7 +35,7 @@ const updateGameCustomAssets = async (
|
||||
) {
|
||||
oldAssetPaths.push(existing.replace("local:", ""));
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
const updatedGame = {
|
||||
...existingGame,
|
||||
@@ -51,7 +51,7 @@ const updateGameCustomAssets = async (
|
||||
if (existingAssets) {
|
||||
const updatedAssets = {
|
||||
...existingAssets,
|
||||
title,
|
||||
title,
|
||||
};
|
||||
|
||||
await gamesShopAssetsSublevel.put(gameKey, updatedAssets);
|
||||
|
||||
@@ -54,7 +54,6 @@ export function EditGameModal({
|
||||
setIconPath(extractLocalPath(game.iconUrl));
|
||||
setLogoPath(extractLocalPath(game.logoImageUrl));
|
||||
setHeroPath(extractLocalPath(game.libraryHeroImageUrl));
|
||||
// For existing assets, show the asset path as display path since we don't have the original
|
||||
setIconDisplayPath(extractLocalPath(game.iconUrl));
|
||||
setLogoDisplayPath(extractLocalPath(game.logoImageUrl));
|
||||
setHeroDisplayPath(extractLocalPath(game.libraryHeroImageUrl));
|
||||
@@ -65,7 +64,6 @@ export function EditGameModal({
|
||||
setIconPath(extractLocalPath(game.customIconUrl));
|
||||
setLogoPath(extractLocalPath(game.customLogoImageUrl));
|
||||
setHeroPath(extractLocalPath(game.customHeroImageUrl));
|
||||
// For existing assets, show the asset path as display path since we don't have the original
|
||||
setIconDisplayPath(extractLocalPath(game.customIconUrl));
|
||||
setLogoDisplayPath(extractLocalPath(game.customLogoImageUrl));
|
||||
setHeroDisplayPath(extractLocalPath(game.customHeroImageUrl));
|
||||
|
||||
Reference in New Issue
Block a user