Group backends in a dedicated source directory (#189)

src/CMakeLists.txt

@@ -1,15 +1,10 @@
 add_subdirectory(common)
 add_subdirectory(emulator)
 add_subdirectory(gdb-stub)
-add_subdirectory(unicorn-emulator)
+add_subdirectory(backends)
 add_subdirectory(windows-emulator)
 add_subdirectory(windows-gdb-stub)
 
-if (MOMO_ENABLE_RUST_CODE)
-    add_subdirectory(icicle-emulator)
-    add_subdirectory(icicle)
-endif()
-
 if (NOT MOMO_BUILD_AS_LIBRARY)
     add_subdirectory(analyzer)
     add_subdirectory(fuzzing-engine)

src/analyzer/snapshot.cpp

@@ -18,8 +18,8 @@ namespace snapshot
 
         std::span<const std::byte> validate_header(const std::span<const std::byte> snapshot)
         {
-            snapshot_header default_header;
             snapshot_header header{};
+            constexpr snapshot_header default_header{};
 
             if (snapshot.size() < sizeof(header))
             {

src/backends/CMakeLists.txt

@@ -0,0 +1,5 @@
+add_subdirectory(unicorn-emulator)
+
+if (MOMO_ENABLE_RUST_CODE)
+  add_subdirectory(icicle-emulator)
+endif()

src/backends/icicle-emulator/CMakeLists.txt

@@ -1,3 +1,5 @@
+add_subdirectory(icicle-bridge)
+
 file(GLOB_RECURSE SRC_FILES CONFIGURE_DEPENDS
   *.cpp
   *.hpp
@@ -15,4 +17,4 @@ endif()
 target_include_directories(icicle-emulator INTERFACE "${CMAKE_CURRENT_LIST_DIR}")
 
 target_link_libraries(icicle-emulator PUBLIC emulator)
-target_link_libraries(icicle-emulator PRIVATE emulator-common icicle)
+target_link_libraries(icicle-emulator PRIVATE emulator-common icicle-bridge)

src/backends/icicle-emulator/icicle-bridge/CMakeLists.txt

@@ -51,12 +51,12 @@ add_custom_command(
     COMMENT "Copying Ghidra Processor Specification"
 )
 
-add_library(icicle INTERFACE)
-add_dependencies(icicle icicle-rust-project)
-target_link_libraries(icicle INTERFACE ${ICICLE_RUST_LIB})
+add_library(icicle-bridge INTERFACE)
+add_dependencies(icicle-bridge icicle-rust-project)
+target_link_libraries(icicle-bridge INTERFACE ${ICICLE_RUST_LIB})
 
 if(MSVC)
-  target_link_libraries(icicle INTERFACE
+  target_link_libraries(icicle-bridge INTERFACE
     ws2_32.lib
     Userenv.lib
     ntdll.lib